Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1687)

Unified Diff: base/debug_util.h

Issue 272025: Trim the list of signals used by debug_util::DisableOSCrashDumps() on Mac (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/debug_util_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug_util.h
===================================================================
--- base/debug_util.h (revision 28692)
+++ base/debug_util.h (working copy)
@@ -75,12 +75,10 @@
static void BreakDebugger();
#if defined(OS_MACOSX)
- // On OS X, it can take a really long time for the OS Crash handler to
- // process a Chrome crash. This translates into a long wait till the process
- // actually dies.
- // This method disables OS Crash reporting entireley.
- // TODO(playmobil): Remove this when we have Breakpad integration enabled -
- // see http://crbug.com/7652
+ // On Mac OS X, it can take a really long time for the OS crash handler to
+ // process a Chrome crash when debugging symbols are available. This
+ // translates into a long wait until the process actually dies. This call
+ // disables Apple Crash Reporter entirely.
static void DisableOSCrashDumps();
#endif // defined(OS_MACOSX)
};
« no previous file with comments | « no previous file | base/debug_util_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698