Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2720123002:
Convert editing/pasteboard/paste-xml.xhtml with w3c testharness (Closed)
DescriptionConvert editing/pasteboard/paste-xml.xhtml with w3c testharness
This patch converts the above mentioned layout test with w3c
testharness to promote the use of w3c testharness and improve code health.
This is also preparation for https://codereview.chromium.org/2720063002
BUG=679977
Review-Url: https://codereview.chromium.org/2720123002
Cr-Commit-Position: refs/heads/master@{#453791}
Committed: https://chromium.googlesource.com/chromium/src/+/5416bc4d2f3a8519aaa5feece75383ea020ed638
Patch Set 1 #
Total comments: 5
Patch Set 2 : Use plain testharness #
Total comments: 1
Dependent Patchsets: Messages
Total messages: 22 (14 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Convert editing/pasteboard/paste-xml.xhtml with assert_selection BUG= ========== to ========== Convert editing/pasteboard/paste-xml.xhtml with assert_selection This patch converts the above mentioned layout test with assert_selection to promote the use of w3c testharness and improve code health. This is also preparation for https://codereview.chromium.org/2720063002 BUG=679977 ==========
xiaochengh@chromium.org changed reviewers: + tkent@chromium.org, yoichio@chromium.org, yosin@chromium.org
PTAL.
https://codereview.chromium.org/2720123002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml (right): https://codereview.chromium.org/2720123002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml:1: <!DOCTYPE html> I'm not sure whether we should have full DOCTYPE, as original, or shorthand[1]. [1] https://www.w3.org/TR/xhtml11/conformance.html#s_conform https://codereview.chromium.org/2720123002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml:23: 'foo barbar| baz', Could you copy and paste with element? It seems original test checks we insert "<span xmlns="http://www.w3.org/1999/xhtml">" for copying/pasting "<span>".
https://codereview.chromium.org/2720123002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml (right): https://codereview.chromium.org/2720123002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml:1: <!DOCTYPE html> On 2017/02/28 at 01:50:06, yosin_UTC9 wrote: > I'm not sure whether we should have full DOCTYPE, as original, or shorthand[1]. > > [1] https://www.w3.org/TR/xhtml11/conformance.html#s_conform I have no idea either... We should check with someone else. https://codereview.chromium.org/2720123002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml:23: 'foo barbar| baz', On 2017/02/28 at 01:50:06, yosin_UTC9 wrote: > Could you copy and paste with element? > It seems original test checks we insert "<span xmlns="http://www.w3.org/1999/xhtml">" for copying/pasting "<span>". Testing with xhtml seems more tricky than ordinary html. I haven't managed to create a subframe with xml content. When setting the innerHTML of a subframe to <html xmlns="..."></html>, the "xmlns" attr is dropped.
https://codereview.chromium.org/2720123002/diff/1/third_party/WebKit/LayoutTe... File third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml (right): https://codereview.chromium.org/2720123002/diff/1/third_party/WebKit/LayoutTe... third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml:23: 'foo barbar| baz', On 2017/02/28 at 03:17:50, Xiaocheng wrote: > On 2017/02/28 at 01:50:06, yosin_UTC9 wrote: > > Could you copy and paste with element? > > It seems original test checks we insert "<span xmlns="http://www.w3.org/1999/xhtml">" for copying/pasting "<span>". > > Testing with xhtml seems more tricky than ordinary html. > > I haven't managed to create a subframe with xml content. When setting the innerHTML of a subframe to <html xmlns="..."></html>, the "xmlns" attr is dropped. Good point. There are two options: 1. Add an option to ask |assert_selection()| to create XMLDocument instead of HTMLDocument. 2. Use W3C test only. It seems option 2 is easier.
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Description was changed from ========== Convert editing/pasteboard/paste-xml.xhtml with assert_selection This patch converts the above mentioned layout test with assert_selection to promote the use of w3c testharness and improve code health. This is also preparation for https://codereview.chromium.org/2720063002 BUG=679977 ========== to ========== Convert editing/pasteboard/paste-xml.xhtml with w3c testharness This patch converts the above mentioned layout test with w3c testharness to promote the use of w3c testharness and improve code health. This is also preparation for https://codereview.chromium.org/2720063002 BUG=679977 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Updated with option 2. PTAL.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm I'm used to love XML. But, now... https://codereview.chromium.org/2720123002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml (right): https://codereview.chromium.org/2720123002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/editing/pasteboard/paste-xml.xhtml:25: const expectedText = '\n<span xmlns=\"http://www.w3.org/1999/xhtml\" id=\"test\">foo barbar baz</span>\n'; :-)
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488332305577080,
"parent_rev": "977ff883dfd769b8b79bdb73ed3544b5fa971abb", "commit_rev":
"5416bc4d2f3a8519aaa5feece75383ea020ed638"}
Message was sent while issue was closed.
Description was changed from ========== Convert editing/pasteboard/paste-xml.xhtml with w3c testharness This patch converts the above mentioned layout test with w3c testharness to promote the use of w3c testharness and improve code health. This is also preparation for https://codereview.chromium.org/2720063002 BUG=679977 ========== to ========== Convert editing/pasteboard/paste-xml.xhtml with w3c testharness This patch converts the above mentioned layout test with w3c testharness to promote the use of w3c testharness and improve code health. This is also preparation for https://codereview.chromium.org/2720063002 BUG=679977 Review-Url: https://codereview.chromium.org/2720123002 Cr-Commit-Position: refs/heads/master@{#453791} Committed: https://chromium.googlesource.com/chromium/src/+/5416bc4d2f3a8519aaa5feece753... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5416bc4d2f3a8519aaa5feece753... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
