Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2720013003: [debug] add more tests for side-effect free debug-evaluate. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] add more tests for side-effect free debug-evaluate. R=jgruber@chromium.org BUG=v8:5821 Review-Url: https://codereview.chromium.org/2720013003 Cr-Commit-Position: refs/heads/master@{#43487} Committed: https://chromium.googlesource.com/v8/v8/+/a35616e32425b2ff9d044bdc705ccc3542077b51

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M src/debug/debug-evaluate.cc View 1 chunk +6 lines, -1 line 0 comments Download
M test/debugger/debug/debug-evaluate-no-side-effect.js View 4 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Yang
3 years, 9 months ago (2017-02-28 13:49:49 UTC) #1
jgruber
lgtm
3 years, 9 months ago (2017-02-28 13:56:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2720013003/1
3 years, 9 months ago (2017-02-28 13:59:51 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 14:23:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/a35616e32425b2ff9d044bdc705ccc35420...

Powered by Google App Engine
This is Rietveld 408576698