Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/debug/debug-evaluate.cc

Issue 2720013003: [debug] add more tests for side-effect free debug-evaluate. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/debugger/debug/debug-evaluate-no-side-effect.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug-evaluate.cc
diff --git a/src/debug/debug-evaluate.cc b/src/debug/debug-evaluate.cc
index c6fafa557b7da20e706578f89ee89b5cc8ef5eef..1be25895cef450933d2a69b505d746a0f84d75d2 100644
--- a/src/debug/debug-evaluate.cc
+++ b/src/debug/debug-evaluate.cc
@@ -504,7 +504,12 @@ bool BuiltinHasNoSideEffect(Builtins::Name id) {
static const Address accessors_with_no_side_effect[] = {
// Whitelist for accessors.
FUNCTION_ADDR(Accessors::StringLengthGetter),
- FUNCTION_ADDR(Accessors::ArrayLengthGetter)};
+ FUNCTION_ADDR(Accessors::ArrayLengthGetter),
+ FUNCTION_ADDR(Accessors::FunctionLengthGetter),
+ FUNCTION_ADDR(Accessors::FunctionNameGetter),
+ FUNCTION_ADDR(Accessors::BoundFunctionLengthGetter),
+ FUNCTION_ADDR(Accessors::BoundFunctionNameGetter),
+};
} // anonymous namespace
« no previous file with comments | « no previous file | test/debugger/debug/debug-evaluate-no-side-effect.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698