Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2719993006: Make kbps optional when computing effective connection type (Closed)

Created:
3 years, 9 months ago by tbansal1
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, tbansal+watch-nqe_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. This change only affects GetRecentEffectiveConnectionType(), and not GetEffectiveConnectionType(). The former is used only for recording accuracy. BUG=696616 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2717883002 Cr-Commit-Position: refs/heads/master@{#453394} (cherry picked from commit 73f1a3b3440892c277003ef73862420592b93ab6) Review-Url: https://codereview.chromium.org/2719993006 . Cr-Commit-Position: refs/branch-heads/2987@{#722} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/3b97fc71698dc30f5a51e6c16565b85868a3d1ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M net/nqe/network_quality_estimator.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tbansal1
3 years, 9 months ago (2017-02-28 20:56:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b97fc71698dc30f5a51e6c16565b85868a3d1ab.

Powered by Google App Engine
This is Rietveld 408576698