Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2717883002:
Make kbps optional when computing effective connection type (Closed)
DescriptionMake kbps optional when computing effective connection type
Make kbps optional when computing effective connection type since
the kbps is always available.
This change only affects GetRecentEffectiveConnectionType(), and not
GetEffectiveConnectionType(). The former is used only for recording
accuracy.
BUG=696616
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2717883002
Cr-Commit-Position: refs/heads/master@{#453394}
Committed: https://chromium.googlesource.com/chromium/src/+/73f1a3b3440892c277003ef73862420592b93ab6
Patch Set 1 : ps #
Messages
Total messages: 22 (16 generated)
Description was changed from ========== Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. BUG= ========== to ========== Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. BUG=696616 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
Description was changed from ========== Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. BUG=696616 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. This change only affects GetRecentEffectiveConnectionType(), and not GetEffectiveConnectionType(). The former is used only for recording accuracy. BUG=696616 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
tbansal@chromium.org changed reviewers: + ryansturm@chromium.org
ryansturm: ptal. Thanks.
lgtm
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tbansal@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488235264414720,
"parent_rev": "d9fd37f3280a4e6373b359b8fabf3ec7fc4dff2f", "commit_rev":
"73f1a3b3440892c277003ef73862420592b93ab6"}
Message was sent while issue was closed.
Description was changed from ========== Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. This change only affects GetRecentEffectiveConnectionType(), and not GetEffectiveConnectionType(). The former is used only for recording accuracy. BUG=696616 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Make kbps optional when computing effective connection type Make kbps optional when computing effective connection type since the kbps is always available. This change only affects GetRecentEffectiveConnectionType(), and not GetEffectiveConnectionType(). The former is used only for recording accuracy. BUG=696616 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2717883002 Cr-Commit-Position: refs/heads/master@{#453394} Committed: https://chromium.googlesource.com/chromium/src/+/73f1a3b3440892c277003ef73862... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/73f1a3b3440892c277003ef73862... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
