Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2719893002: //third_party/WebKit/Source/web: include v8 as a user, not system, header (Closed)

Created:
3 years, 9 months ago by dcheng
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, caseq+blink_chromium.org, tzik, nhiroki, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, lushnikov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//third_party/WebKit/Source/web: include v8 as a user, not system, header Note: due to an issue with v8's GN files, files that use include v8 inspector headers are being skipped for now. BUG=688155 Review-Url: https://codereview.chromium.org/2719893002 Cr-Commit-Position: refs/heads/master@{#453184} Committed: https://chromium.googlesource.com/chromium/src/+/e5739d00dd6cd1c4c4126bc9053b0a9905549711

Patch Set 1 #

Patch Set 2 : Revert things that use inspector headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M third_party/WebKit/Source/web/SuspendableScriptExecutor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebCryptoNormalize.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDOMFileSystem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebTestingSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
dcheng
3 years, 9 months ago (2017-02-27 08:49:52 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-02-27 08:52:43 UTC) #5
dcheng
Due to the inspector include issues, reverting files that include v8 inspector headers for now ...
3 years, 9 months ago (2017-02-27 09:22:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719893002/20001
3 years, 9 months ago (2017-02-27 09:22:55 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 10:54:05 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e5739d00dd6cd1c4c4126bc9053b...

Powered by Google App Engine
This is Rietveld 408576698