third_party/WebKit/Source/web/WebKit.cpp - Issue 2719893002: //third_party/WebKit/Source/web: include v8 as a user, not system, header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebKit.cpp

Issue 2719893002: //third_party/WebKit/Source/web: include v8 as a user, not system, header (Closed)

Patch Set: Revert things that use inspector headers. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebKit.cpp

diff --git a/third_party/WebKit/Source/web/WebKit.cpp b/third_party/WebKit/Source/web/WebKit.cpp

index ccc79f25e88bbf95d07ddee8936217f5f5817f94..0bcd0fb709007e70294ce6dbada99efe04bc13b6 100644

--- a/third_party/WebKit/Source/web/WebKit.cpp

+++ b/third_party/WebKit/Source/web/WebKit.cpp

@@ -30,6 +30,8 @@

#include "public/web/WebKit.h"

+#include <memory>

#include "bindings/core/v8/Microtask.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/core/v8/V8GCController.h"

@@ -44,14 +46,13 @@

#include "platform/heap/Heap.h"

#include "public/platform/Platform.h"

#include "public/platform/WebThread.h"

+#include "v8/include/v8.h"

#include "wtf/Assertions.h"

#include "wtf/PtrUtil.h"

#include "wtf/WTF.h"

#include "wtf/allocator/Partitions.h"

#include "wtf/text/AtomicString.h"

#include "wtf/text/TextEncoding.h"

-#include <memory>

-#include <v8.h>

namespace blink {