Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/perf/page_sets/system_health/long_running_stories.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/system_health/long_running_stories.py
diff --git a/tools/perf/page_sets/system_health/long_running_stories.py b/tools/perf/page_sets/system_health/long_running_stories.py
index 809971d85576db9ec80981b3dc1b024f8db6d536..a32ea451042d077a37e124b23dc57a1a60f27e13 100644
--- a/tools/perf/page_sets/system_health/long_running_stories.py
+++ b/tools/perf/page_sets/system_health/long_running_stories.py
@@ -65,12 +65,12 @@ class _LongRunningGmailMobileBase(_LongRunningGmailBase):
def _DidLoadDocument(self, action_runner):
# Close the "Get Inbox by Gmail" interstitial.
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'document.querySelector("#isppromo a") !== null')
- action_runner.ExecuteJavaScript2(
+ action_runner.ExecuteJavaScript(
'document.querySelector("#isppromo a").click()')
# Wait until the UI loads.
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'document.getElementById("apploadingdiv").style.height === "0px"')
@@ -79,7 +79,7 @@ class _LongRunningGmailDesktopBase(_LongRunningGmailBase):
def _DidLoadDocument(self, action_runner):
# Wait until the UI loads.
- action_runner.WaitForJavaScriptCondition2(
+ action_runner.WaitForJavaScriptCondition(
'document.getElementById("loading").style.display === "none"')
« no previous file with comments | « tools/perf/page_sets/system_health/loading_stories.py ('k') | tools/perf/page_sets/system_health/media_stories.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698