Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: tools/perf/page_sets/login_helpers/google_login.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/login_helpers/google_login.py
diff --git a/tools/perf/page_sets/login_helpers/google_login.py b/tools/perf/page_sets/login_helpers/google_login.py
index e41bb07a3fc1c6dd23eee6f8a00f46ebb39527b2..a1108e4ce6185922faeaf1798672444c70c4fa03 100644
--- a/tools/perf/page_sets/login_helpers/google_login.py
+++ b/tools/perf/page_sets/login_helpers/google_login.py
@@ -43,13 +43,13 @@ def LoginGoogleAccount(action_runner,
'https%3A%2F%2Faccounts.google.com%2FManageAccount')
# Wait until either the email or password input is visible.
- action_runner.WaitForJavaScriptCondition2('{{ @a }} || {{ @b }}',
+ action_runner.WaitForJavaScriptCondition('{{ @a }} || {{ @b }}',
a=_EMAIL_INPUT_VISIBLE_CONDITION, b=_PASSWORD_INPUT_VISIBLE_CONDITION)
# If the email input is visible, this is the first Google login within the
# browser session, so we must enter both email and password. Otherwise, only
# password is required.
- if action_runner.EvaluateJavaScript2(_EMAIL_INPUT_VISIBLE_CONDITION):
+ if action_runner.EvaluateJavaScript(_EMAIL_INPUT_VISIBLE_CONDITION):
login_utils.InputForm(action_runner, account_name, input_id='Email',
form_id='gaia_firstform')
action_runner.ClickElement(selector='#gaia_firstform #next')
« no previous file with comments | « tools/perf/page_sets/login_helpers/dropbox_login.py ('k') | tools/perf/page_sets/login_helpers/login_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698