Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: tools/perf/page_sets/blank_page.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/metrics/webrtc_stats_unittest.py ('k') | tools/perf/page_sets/blink_memory_mobile.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/blank_page.py
diff --git a/tools/perf/page_sets/blank_page.py b/tools/perf/page_sets/blank_page.py
index 6719096a96fc8df571e8dfe06c9918db15678bc3..1858cfa2f31538951f6cd576d99b6e8582e28263 100644
--- a/tools/perf/page_sets/blank_page.py
+++ b/tools/perf/page_sets/blank_page.py
@@ -13,7 +13,7 @@ class BlankPage(page_module.Page):
def RunPageInteractions(self, action_runner):
# Request a RAF and wait for it to be processed to ensure that the metric
# Startup.FirstWebContents.NonEmptyPaint2 is recorded.
- action_runner.ExecuteJavaScript2(
+ action_runner.ExecuteJavaScript(
"""
this.hasRunRAF = 0;
requestAnimationFrame(function() {
@@ -21,7 +21,7 @@ class BlankPage(page_module.Page):
});
"""
)
- action_runner.WaitForJavaScriptCondition2("this.hasRunRAF == 1")
+ action_runner.WaitForJavaScriptCondition("this.hasRunRAF == 1")
class BlankPageSet(story.StorySet):
"""A single blank page."""
@@ -39,7 +39,7 @@ class BlankPageTBM(page_module.Page):
shared_page_state_class=BrowserStartupSharedState)
def RunPageInteractions(self, action_runner):
- action_runner.ExecuteJavaScript2(
+ action_runner.ExecuteJavaScript(
"""
this.hasRunRAF = 0;
requestAnimationFrame(function() {
@@ -47,7 +47,7 @@ class BlankPageTBM(page_module.Page):
});
"""
)
- action_runner.WaitForJavaScriptCondition2("this.hasRunRAF == 1")
+ action_runner.WaitForJavaScriptCondition("this.hasRunRAF == 1")
class BlankPageSetTBM(story.StorySet):
« no previous file with comments | « tools/perf/metrics/webrtc_stats_unittest.py ('k') | tools/perf/page_sets/blink_memory_mobile.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698