tools/perf/benchmarks/blink_perf.py - Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 2719853003: [Telemetry refactor] Drop "2" from method calls to JS API (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/benchmarks/blink_perf.py

diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py

index 743656c35bfeb16e19f53598e586f5efe2a4a779..7b43df3286bd316e2fb4e03de2623890277fd8aa 100644

--- a/tools/perf/benchmarks/blink_perf.py

+++ b/tools/perf/benchmarks/blink_perf.py

@@ -97,9 +97,9 @@ class _BlinkPerfMeasurement(legacy_page_test.LegacyPageTest):

options.AppendExtraBrowserArgs('--expose-internals-for-testing')

def ValidateAndMeasurePage(self, page, tab, results):

- tab.WaitForJavaScriptCondition2('testRunner.isDone', timeout=600)

+ tab.WaitForJavaScriptCondition('testRunner.isDone', timeout=600)

- log = tab.EvaluateJavaScript2('document.getElementById("log").innerHTML')

+ log = tab.EvaluateJavaScript('document.getElementById("log").innerHTML')

for line in log.splitlines():

if line.startswith("FATAL: "):