[inspector] added step-into test to cover most stepInto cases

[inspector] added step-into test to cover most stepInto cases

This test helps to prevent regressions during work on new break locations.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2719763002
Cr-Commit-Position: refs/heads/master@{#43458}
Committed: https://chromium.googlesource.com/v8/v8/+/c63e83c1e97d4605ab3499828b0a9f0e88f90ac2

[kozy, 2017-02-26 08:30:17]

Dmitry, please take a look.

https://codereview.chromium.org/2719763002/diff/1/test/inspector/debugger/ste...
File test/inspector/debugger/step-into-expected.txt (right):

https://codereview.chromium.org/2719763002/diff/1/test/inspector/debugger/ste...
test/inspector/debugger/step-into-expected.txt:10: // comment onl#y
issue - will fix it in followup.

https://codereview.chromium.org/2719763002/diff/1/test/inspector/debugger/ste...
test/inspector/debugger/step-into-expected.txt:712: #yield 3;
this behavior is issue. I'll fix it in follow up.

[kozy, 2017-02-27 17:34:55]

Patchset #2 (id:20001) has been deleted

[dgozman, 2017-02-27 17:56:48]

lgtm

https://codereview.chromium.org/2719763002/diff/40001/test/inspector/debugger...
File test/inspector/debugger/step-into-expected.txt (right):

https://codereview.chromium.org/2719763002/diff/40001/test/inspector/debugger...
test/inspector/debugger/step-into-expected.txt:121:
#twoArguments(emptyFunction(), emptyFunction());
Having this and line 141 is a bit confusing.

https://codereview.chromium.org/2719763002/diff/40001/test/inspector/debugger...
File test/inspector/debugger/step-into.js (right):

https://codereview.chromium.org/2719763002/diff/40001/test/inspector/debugger...
test/inspector/debugger/step-into.js:222: await awaitBoo();
Let's add that example where we skip something with to awaits. IIRC, you need
new Promise() in asyncBoo, and we skip it's body. Or something like that.

[kozy, 2017-02-27 18:35:08]

thanks, all done.

https://codereview.chromium.org/2719763002/diff/40001/test/inspector/debugger...
File test/inspector/debugger/step-into-expected.txt (right):

https://codereview.chromium.org/2719763002/diff/40001/test/inspector/debugger...
test/inspector/debugger/step-into-expected.txt:121:
#twoArguments(emptyFunction(), emptyFunction());
On 2017/02/27 17:56:48, dgozman wrote:
> Having this and line 141 is a bit confusing.

Yes, it should be before first emptyFunction().

https://codereview.chromium.org/2719763002/diff/40001/test/inspector/debugger...
File test/inspector/debugger/step-into.js (right):

https://codereview.chromium.org/2719763002/diff/40001/test/inspector/debugger...
test/inspector/debugger/step-into.js:222: await awaitBoo();
On 2017/02/27 17:56:48, dgozman wrote:
> Let's add that example where we skip something with to awaits. IIRC, you need
> new Promise() in asyncBoo, and we skip it's body. Or something like that.

I added a test for some code in the middle and behavior looks super strange -
added todo to fix it, will take a look.

[kozy, 2017-02-27 18:35:15]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-27 18:35:15]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2719763002/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-02-27 18:35:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 18:58:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488220515450450,
"parent_rev": "4d7fa10c2bb08343417e448208976ab63cac08c6", "commit_rev":
"c63e83c1e97d4605ab3499828b0a9f0e88f90ac2"}

[commit-bot: I haz the power, 2017-02-27 18:59:01]

Description was changed from

==========
[inspector] added step-into test to cover most stepInto cases

This test helps to prevent regressions during work on new break locations.

BUG=none
R=dgozman@chromium.org
==========

to

==========
[inspector] added step-into test to cover most stepInto cases

This test helps to prevent regressions during work on new break locations.

BUG=none
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2719763002
Cr-Commit-Position: refs/heads/master@{#43458}
Committed:
https://chromium.googlesource.com/v8/v8/+/c63e83c1e97d4605ab3499828b0a9f0e88f...
==========

[commit-bot: I haz the power, 2017-02-27 18:59:01]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/c63e83c1e97d4605ab3499828b0a9f0e88f...