Update VTTCue enum AlignSetting, "middle" -> "center"

Update VTTCue enum AlignSetting, "middle" -> "center"

Apparently this was missed in https://codereview.chromium.org/2683633006

R=foolip@chromium.org
BUG=663797
Review-Url: https://codereview.chromium.org/2719513002
Cr-Commit-Position: refs/heads/master@{#453121}
Committed: https://chromium.googlesource.com/chromium/src/+/91f02e878fc3c4c471b0d4e6004b04d1cdbc653e

[fs, 2017-02-24 16:06:10]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 16:06:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-02-24 16:41:05]

I guess this means we have no tests that try to set the attribute to "middle" or
"center"? Trying to set it to "middle" might make sense as an historical.html
test in web-platform-tests.

Some tests are in flight at https://codereview.chromium.org/2711183003/ but I
think it's just renames.

[foolip, 2017-02-24 16:41:29]

lgtm % some minimal test coverage for this

[fs, 2017-02-24 17:24:10]

On 2017/02/24 at 16:41:05, foolip wrote:
> I guess this means we have no tests that try to set the attribute to "middle"
or "center"? Trying to set it to "middle" might make sense as an historical.html
test in web-platform-tests.
> 
> Some tests are in flight at https://codereview.chromium.org/2711183003/ but I
think it's just renames.

Yes, I think we essentially ditched those with the CL I mentioned in the
description... We crash for the CL you referenced, so I'd prefer to land this
ASAP for that reason. Can try to get something in for setting 'middle' (either
in historical.html or elsewhere) after that.

[commit-bot: I haz the power, 2017-02-24 17:48:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 17:48:01]

Dry run: This issue passed the CQ dry run.

[foolip, 2017-02-26 14:55:36]

On 2017/02/24 17:24:10, fs wrote:
> On 2017/02/24 at 16:41:05, foolip wrote:
> > I guess this means we have no tests that try to set the attribute to
"middle"
> or "center"? Trying to set it to "middle" might make sense as an
historical.html
> test in web-platform-tests.
> > 
> > Some tests are in flight at https://codereview.chromium.org/2711183003/ but
I
> think it's just renames.
> 
> Yes, I think we essentially ditched those with the CL I mentioned in the
> description... We crash for the CL you referenced, so I'd prefer to land this
> ASAP for that reason. Can try to get something in for setting 'middle' (either
> in historical.html or elsewhere) after that.

SGTM, if it's not too late already.

[fs, 2017-02-26 15:19:20]

On 2017/02/26 at 14:55:36, foolip wrote:
> On 2017/02/24 17:24:10, fs wrote:
> > On 2017/02/24 at 16:41:05, foolip wrote:
> > > I guess this means we have no tests that try to set the attribute to
"middle"
> > or "center"? Trying to set it to "middle" might make sense as an
historical.html
> > test in web-platform-tests.
> > > 
> > > Some tests are in flight at https://codereview.chromium.org/2711183003/
but I
> > think it's just renames.
> > 
> > Yes, I think we essentially ditched those with the CL I mentioned in the
> > description... We crash for the CL you referenced, so I'd prefer to land
this
> > ASAP for that reason. Can try to get something in for setting 'middle'
(either
> > in historical.html or elsewhere) after that.
> 
> SGTM, if it's not too late already.

I don't see that anything happened to change the situation (and the import seems
to have failed), so I'll go ahead and land this. Will try to get a test done
tomorrow.

[fs, 2017-02-26 15:19:24]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2017-02-26 15:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-02-26 16:39:44]

On 2017/02/26 at 15:19:20, fs wrote:
> On 2017/02/26 at 14:55:36, foolip wrote:
> > On 2017/02/24 17:24:10, fs wrote:
> > > On 2017/02/24 at 16:41:05, foolip wrote:
> > > > I guess this means we have no tests that try to set the attribute to
"middle"
> > > or "center"? Trying to set it to "middle" might make sense as an
historical.html
> > > test in web-platform-tests.
> > > > 
> > > > Some tests are in flight at https://codereview.chromium.org/2711183003/
but I
> > > think it's just renames.
> > > 
> > > Yes, I think we essentially ditched those with the CL I mentioned in the
> > > description... We crash for the CL you referenced, so I'd prefer to land
this
> > > ASAP for that reason. Can try to get something in for setting 'middle'
(either
> > > in historical.html or elsewhere) after that.
> > 
> > SGTM, if it's not too late already.
> 
> I don't see that anything happened to change the situation (and the import
seems to have failed), so I'll go ahead and land this. Will try to get a test
done tomorrow.

Looks like the tests landed via https://chromium-review.googlesource.com/446725.
Good news is that 'middle' is tested by the new WPT test, so the testing part is
at least somewhat covered. (Not seeing proper coverage of 'center' though, so
should probably add that.) Will change this to update expectations.

[fs, 2017-02-26 16:44:36]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 16:44:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 18:32:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 18:32:40]

Dry run: This issue passed the CQ dry run.

[fs, 2017-02-26 18:33:42]

The CQ bit was checked by fs@opera.com

[fs, 2017-02-26 18:33:43]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2719513002/#ps20001
(title: "Fix expectations")

[commit-bot: I haz the power, 2017-02-26 18:33:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 20:45:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488134022838130,
"parent_rev": "00109a3ffd77b5ee226bf6584a18f16ba85ce5c2", "commit_rev":
"91f02e878fc3c4c471b0d4e6004b04d1cdbc653e"}

[commit-bot: I haz the power, 2017-02-26 20:46:35]

Description was changed from

==========
Update VTTCue enum AlignSetting, "middle" -> "center"

Apparently this was missed in https://codereview.chromium.org/2683633006

R=foolip@chromium.org
BUG=663797
==========

to

==========
Update VTTCue enum AlignSetting, "middle" -> "center"

Apparently this was missed in https://codereview.chromium.org/2683633006

R=foolip@chromium.org
BUG=663797

Review-Url: https://codereview.chromium.org/2719513002
Cr-Commit-Position: refs/heads/master@{#453121}
Committed:
https://chromium.googlesource.com/chromium/src/+/91f02e878fc3c4c471b0d4e6004b...
==========

[commit-bot: I haz the power, 2017-02-26 20:46:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/91f02e878fc3c4c471b0d4e6004b...