Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Side by Side Diff: third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl

Issue 2719513002: Update VTTCue enum AlignSetting, "middle" -> "center" (Closed)
Patch Set: Fix expectations Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/webvtt/api/VTTCue/align-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Opera Software ASA. All rights reserved. 2 * Copyright (c) 2013, Opera Software ASA. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED 26 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
27 * OF THE POSSIBILITY OF SUCH DAMAGE. 27 * OF THE POSSIBILITY OF SUCH DAMAGE.
28 */ 28 */
29 29
30 // https://w3c.github.io/webvtt/#the-vttcue-interface 30 // https://w3c.github.io/webvtt/#the-vttcue-interface
31 31
32 enum AutoKeyword { "auto" }; 32 enum AutoKeyword { "auto" };
33 enum DirectionSetting { "" /* horizontal */, "rl", "lr" }; 33 enum DirectionSetting { "" /* horizontal */, "rl", "lr" };
34 // enum LineAlignSetting { "start", "middle", "end" }; 34 // enum LineAlignSetting { "start", "middle", "end" };
35 // enum PositionAlignSetting { "start", "middle", "end", "auto" }; 35 // enum PositionAlignSetting { "start", "middle", "end", "auto" };
36 enum AlignSetting { "start", "middle", "end", "left", "right" }; 36 enum AlignSetting { "start", "center", "end", "left", "right" };
37 37
38 [ 38 [
39 Constructor(double startTime, double endTime, DOMString text), 39 Constructor(double startTime, double endTime, DOMString text),
40 ConstructorCallWith=Document, 40 ConstructorCallWith=Document,
41 DependentLifetime, 41 DependentLifetime,
42 ] interface VTTCue : TextTrackCue { 42 ] interface VTTCue : TextTrackCue {
43 [RuntimeEnabled=WebVTTRegions] attribute VTTRegion? region; 43 [RuntimeEnabled=WebVTTRegions] attribute VTTRegion? region;
44 attribute DirectionSetting vertical; 44 attribute DirectionSetting vertical;
45 attribute boolean snapToLines; 45 attribute boolean snapToLines;
46 attribute (double or AutoKeyword) line; 46 attribute (double or AutoKeyword) line;
47 // attribute LineAlignSetting lineAlign; 47 // attribute LineAlignSetting lineAlign;
48 [RaisesException=Setter] attribute (double or AutoKeyword) position; 48 [RaisesException=Setter] attribute (double or AutoKeyword) position;
49 // attribute PositionAlignSetting positionAlign; 49 // attribute PositionAlignSetting positionAlign;
50 [RaisesException=Setter] attribute double size; 50 [RaisesException=Setter] attribute double size;
51 attribute AlignSetting align; 51 attribute AlignSetting align;
52 attribute DOMString text; 52 attribute DOMString text;
53 DocumentFragment getCueAsHTML(); 53 DocumentFragment getCueAsHTML();
54 }; 54 };
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/webvtt/api/VTTCue/align-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698