Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Side by Side Diff: components/ntp_snippets/features.cc

Issue 2719473002: [NTP::PhysicalWeb] Disable feature by default. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/features.h" 5 #include "components/ntp_snippets/features.h"
6 6
7 #include "base/feature_list.h" 7 #include "base/feature_list.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/time/clock.h" 9 #include "base/time/clock.h"
10 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h " 10 #include "components/ntp_snippets/category_rankers/click_based_category_ranker.h "
(...skipping 14 matching lines...) Expand all
25 const base::Feature kSaveToOfflineFeature{ 25 const base::Feature kSaveToOfflineFeature{
26 "NTPSaveToOffline", base::FEATURE_ENABLED_BY_DEFAULT}; 26 "NTPSaveToOffline", base::FEATURE_ENABLED_BY_DEFAULT};
27 27
28 const base::Feature kOfflineBadgeFeature{ 28 const base::Feature kOfflineBadgeFeature{
29 "NTPOfflineBadge", base::FEATURE_ENABLED_BY_DEFAULT}; 29 "NTPOfflineBadge", base::FEATURE_ENABLED_BY_DEFAULT};
30 30
31 const base::Feature kIncreasedVisibility{ 31 const base::Feature kIncreasedVisibility{
32 "NTPSnippetsIncreasedVisibility", base::FEATURE_ENABLED_BY_DEFAULT}; 32 "NTPSnippetsIncreasedVisibility", base::FEATURE_ENABLED_BY_DEFAULT};
33 33
34 const base::Feature kPhysicalWebPageSuggestionsFeature{ 34 const base::Feature kPhysicalWebPageSuggestionsFeature{
35 "NTPPhysicalWebPageSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 35 "NTPPhysicalWebPageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
36 36
37 const base::Feature kContentSuggestionsSource{ 37 const base::Feature kContentSuggestionsSource{
38 "NTPSnippets", base::FEATURE_ENABLED_BY_DEFAULT}; 38 "NTPSnippets", base::FEATURE_ENABLED_BY_DEFAULT};
39 39
40 const base::Feature kForeignSessionsSuggestionsFeature{ 40 const base::Feature kForeignSessionsSuggestionsFeature{
41 "NTPForeignSessionsSuggestions", base::FEATURE_DISABLED_BY_DEFAULT}; 41 "NTPForeignSessionsSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};
42 42
43 const base::Feature kPreferAmpUrlsFeature{"NTPPreferAmpUrls", 43 const base::Feature kPreferAmpUrlsFeature{"NTPPreferAmpUrls",
44 base::FEATURE_ENABLED_BY_DEFAULT}; 44 base::FEATURE_ENABLED_BY_DEFAULT};
45 45
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 if (category_order_value == kCategoryOrderEmergingMarketsOriented) { 112 if (category_order_value == kCategoryOrderEmergingMarketsOriented) {
113 return CategoryOrderChoice::EMERGING_MARKETS_ORIENTED; 113 return CategoryOrderChoice::EMERGING_MARKETS_ORIENTED;
114 } 114 }
115 115
116 LOG(DFATAL) << "The " << kCategoryOrderParameter << " parameter value is '" 116 LOG(DFATAL) << "The " << kCategoryOrderParameter << " parameter value is '"
117 << category_order_value << "'"; 117 << category_order_value << "'";
118 return CategoryOrderChoice::GENERAL; 118 return CategoryOrderChoice::GENERAL;
119 } 119 }
120 120
121 } // namespace ntp_snippets 121 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698