Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2719443003: Reland of Add automated testing to check for page size with scaling (Closed)

Created:
3 years, 9 months ago by Marc Treib
Modified:
3 years, 9 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add automated testing to check for page size with scaling (patchset #1 id:1 of https://codereview.chromium.org/2718513003/ ) Reason for revert: Turns out the original CL was not the cause of the flakiness. Original issue's description: > Revert of Add automated testing to check for page size with scaling (patchset #4 id:60001 of https://codereview.chromium.org/2697683004/ ) > > Reason for revert: > Looks like this causes build bot errors: crbug.com/695760 > > Original issue's description: > > Add automated testing to check for page size with scaling > > > > Ensure correct page size is still passed back with non default scaling > > values - see bug 686384. Also, modify print web view helper to prevent > > any rounding errors from converting dpi -> pixels -> dpi and scaling > > and unscaling. > > > > BUG=686384 > > > > Review-Url: https://codereview.chromium.org/2697683004 > > Cr-Commit-Position: refs/heads/master@{#452737} > > Committed: https://chromium.googlesource.com/chromium/src/+/230c3f1c820ccb738e9715cd45b2b5e049d782d7 > > TBR=thestig@chromium.org,rbpotter@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=686384 > > Review-Url: https://codereview.chromium.org/2718513003 > Cr-Commit-Position: refs/heads/master@{#452763} > Committed: https://chromium.googlesource.com/chromium/src/+/5378c93cfa61880bb755fff32f231fcf06cc8dd2 TBR=thestig@chromium.org,rbpotter@chromium.org,hajimehoshi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686384 Review-Url: https://codereview.chromium.org/2719443003 Cr-Commit-Position: refs/heads/master@{#452801} Committed: https://chromium.googlesource.com/chromium/src/+/b79284c64bbefedf7b9eee4caf42f47f38316733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -17 lines) Patch
M components/printing/renderer/print_web_view_helper.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M components/printing/test/mock_printer.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/printing/test/mock_printer.cc View 3 chunks +12 lines, -1 line 0 comments Download
M components/printing/test/print_mock_render_thread.cc View 2 chunks +26 lines, -2 lines 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 3 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Marc Treib
Created Reland of Add automated testing to check for page size with scaling
3 years, 9 months ago (2017-02-24 12:53:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719443003/1
3 years, 9 months ago (2017-02-24 12:54:08 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-24 12:55:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b79284c64bbefedf7b9eee4caf42...

Powered by Google App Engine
This is Rietveld 408576698