Chromium Code Reviews
DescriptionReland of Add automated testing to check for page size with scaling (patchset #1 id:1 of https://codereview.chromium.org/2718513003/ )
Reason for revert:
Turns out the original CL was not the cause of the flakiness.
Original issue's description:
> Revert of Add automated testing to check for page size with scaling (patchset #4 id:60001 of https://codereview.chromium.org/2697683004/ )
>
> Reason for revert:
> Looks like this causes build bot errors: crbug.com/695760
>
> Original issue's description:
> > Add automated testing to check for page size with scaling
> >
> > Ensure correct page size is still passed back with non default scaling
> > values - see bug 686384. Also, modify print web view helper to prevent
> > any rounding errors from converting dpi -> pixels -> dpi and scaling
> > and unscaling.
> >
> > BUG=686384
> >
> > Review-Url: https://codereview.chromium.org/2697683004
> > Cr-Commit-Position: refs/heads/master@{#452737}
> > Committed: https://chromium.googlesource.com/chromium/src/+/230c3f1c820ccb738e9715cd45b2b5e049d782d7
>
> TBR=thestig@chromium.org,rbpotter@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=686384
>
> Review-Url: https://codereview.chromium.org/2718513003
> Cr-Commit-Position: refs/heads/master@{#452763}
> Committed: https://chromium.googlesource.com/chromium/src/+/5378c93cfa61880bb755fff32f231fcf06cc8dd2
TBR=thestig@chromium.org,rbpotter@chromium.org,hajimehoshi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=686384
Review-Url: https://codereview.chromium.org/2719443003
Cr-Commit-Position: refs/heads/master@{#452801}
Committed: https://chromium.googlesource.com/chromium/src/+/b79284c64bbefedf7b9eee4caf42f47f38316733
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||