Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2718513003: Revert of Add automated testing to check for page size with scaling (Closed)

Created:
3 years, 10 months ago by hajimehoshi
Modified:
3 years, 10 months ago
Reviewers:
Lei Zhang, rbpotter
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add automated testing to check for page size with scaling (patchset #4 id:60001 of https://codereview.chromium.org/2697683004/ ) Reason for revert: Looks like this causes build bot errors: crbug.com/695760 Original issue's description: > Add automated testing to check for page size with scaling > > Ensure correct page size is still passed back with non default scaling > values - see bug 686384. Also, modify print web view helper to prevent > any rounding errors from converting dpi -> pixels -> dpi and scaling > and unscaling. > > BUG=686384 > > Review-Url: https://codereview.chromium.org/2697683004 > Cr-Commit-Position: refs/heads/master@{#452737} > Committed: https://chromium.googlesource.com/chromium/src/+/230c3f1c820ccb738e9715cd45b2b5e049d782d7 TBR=thestig@chromium.org,rbpotter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686384 Review-Url: https://codereview.chromium.org/2718513003 Cr-Commit-Position: refs/heads/master@{#452763} Committed: https://chromium.googlesource.com/chromium/src/+/5378c93cfa61880bb755fff32f231fcf06cc8dd2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -101 lines) Patch
M components/printing/renderer/print_web_view_helper.cc View 2 chunks +13 lines, -10 lines 0 comments Download
M components/printing/test/mock_printer.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/printing/test/mock_printer.cc View 3 chunks +1 line, -12 lines 0 comments Download
M components/printing/test/print_mock_render_thread.cc View 2 chunks +2 lines, -26 lines 0 comments Download
M components/printing/test/print_web_view_helper_browsertest.cc View 3 chunks +0 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hajimehoshi
Created Revert of Add automated testing to check for page size with scaling
3 years, 10 months ago (2017-02-24 05:36:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718513003/1
3 years, 10 months ago (2017-02-24 05:37:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5378c93cfa61880bb755fff32f231fcf06cc8dd2
3 years, 10 months ago (2017-02-24 05:38:52 UTC) #6
Marc Treib
3 years, 10 months ago (2017-02-24 12:53:42 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2719443003/ by treib@chromium.org.

The reason for reverting is: Turns out the original CL was not the cause of the
flakiness..

Powered by Google App Engine
This is Rietveld 408576698