Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2719433002: Revert of [inspector] removed unused #include "include/v8-debug.h" (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
Reviewers:
kozy, dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] removed unused #include "include/v8-debug.h" (patchset #2 id:20001 of https://codereview.chromium.org/2710243002/ ) Reason for revert: breaks presubmit on CI which runs checkdeps Original issue's description: > [inspector] removed unused #include "include/v8-debug.h" > > We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. > > BUG=none > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2710243002 > Cr-Commit-Position: refs/heads/master@{#43398} > Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024c2249 TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2719433002 Cr-Commit-Position: refs/heads/master@{#43404} Committed: https://chromium.googlesource.com/v8/v8/+/157e1e83ec2e4a0c5b3a739fba977accc55fede8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/inspector/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M src/inspector/v8-inspector-impl.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [inspector] removed unused #include "include/v8-debug.h"
3 years, 10 months ago (2017-02-24 08:36:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719433002/1
3 years, 10 months ago (2017-02-24 08:36:14 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 08:36:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/157e1e83ec2e4a0c5b3a739fba977accc55...

Powered by Google App Engine
This is Rietveld 408576698