Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2710243002:
[inspector] removed unused #include "include/v8-debug.h" (Closed)
Description[inspector] removed unused #include "include/v8-debug.h"
We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead.
BUG=none
R=dgozman@chromium.org
Review-Url: https://codereview.chromium.org/2710243002
Cr-Original-Commit-Position: refs/heads/master@{#43398}
Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024c2249
Review-Url: https://codereview.chromium.org/2710243002
Cr-Commit-Position: refs/heads/master@{#43420}
Committed: https://chromium.googlesource.com/v8/v8/+/18f423a9ff12294d4dff16abac983ba384e3ea16
Patch Set 1 #Patch Set 2 : rebased on top of enabling of checkdeps #Patch Set 3 : removed all v8-debug.h from inspector #
Messages
Total messages: 31 (22 generated)
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Dmitry, please take a look.
The CQ bit was checked by kozyatinskiy@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was unchecked by kozyatinskiy@chromium.org
This CL has an open dependency (Issue 2705333005 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by kozyatinskiy@chromium.org
The CQ bit was unchecked by kozyatinskiy@chromium.org
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487892462372080,
"parent_rev": "40ab666bca945fe1bde78e1f20794988851121bf", "commit_rev":
"838b1a8841aba0c421b413c01b0fbd3c024c2249"}
Message was sent while issue was closed.
Description was changed from ========== [inspector] removed unused #include "include/v8-debug.h" We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org ========== to ========== [inspector] removed unused #include "include/v8-debug.h" We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43398} Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024...
Message was sent while issue was closed.
This seems to break checkdeps: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20presubmit/bu... Will probably need to revert for now after the outage...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2719433002/ by machenbach@chromium.org. The reason for reverting is: breaks presubmit on CI which runs checkdeps.
Message was sent while issue was closed.
Description was changed from ========== [inspector] removed unused #include "include/v8-debug.h" We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43398} Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024... ========== to ========== [inspector] removed unused #include "include/v8-debug.h" We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43398} Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024... ==========
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by kozyatinskiy@chromium.org
The CQ bit was checked by kozyatinskiy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2710243002/#ps40001 (title: "removed all v8-debug.h from inspector")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487957935219040,
"parent_rev": "0423341034c767d91128c9fd68e3f51e60359c1c", "commit_rev":
"18f423a9ff12294d4dff16abac983ba384e3ea16"}
Message was sent while issue was closed.
Description was changed from ========== [inspector] removed unused #include "include/v8-debug.h" We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43398} Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024... ========== to ========== [inspector] removed unused #include "include/v8-debug.h" We don't call any of v8::Debug methods in src/inspector codebase and should use debug-interface.h instead. BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2710243002 Cr-Original-Commit-Position: refs/heads/master@{#43398} Committed: https://chromium.googlesource.com/v8/v8/+/838b1a8841aba0c421b413c01b0fbd3c024... Review-Url: https://codereview.chromium.org/2710243002 Cr-Commit-Position: refs/heads/master@{#43420} Committed: https://chromium.googlesource.com/v8/v8/+/18f423a9ff12294d4dff16abac983ba384e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/18f423a9ff12294d4dff16abac983ba384e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
