Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2719083002: Revert of Add dummy file with very long path to test path length limits. (Closed)

Created:
3 years, 9 months ago by qyearsley
Modified:
3 years, 9 months ago
Reviewers:
tkent, foolip
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add dummy file with very long path to test path length limits. (patchset #1 id:1 of https://codereview.chromium.org/2718733002/ ) Reason for revert: (this was a temporary CL to test whether long paths break things) Original issue's description: > Add dummy file with very long path to test path length limits. > > This CL adds a path in Chromium with a total length of 204 from the repo root, which would be the length of a file in LayoutTests/external/wpt/<subpath> where <subpath> is 160 characters. > > So, if this CL doesn't break anything, then http://crrev.com/2708883004 could be committed. > > This CL might break any builders with a checkout directory of about 43 characters or more. > > Context: see http://crrev.com/2708883004 > Review-Url: https://codereview.chromium.org/2718733002 > Cr-Commit-Position: refs/heads/master@{#453109} > Committed: https://chromium.googlesource.com/chromium/src/+/ce0805ea777b313eb24184737d2b0dfde45e8c69 TBR=tkent@chromium.org,foolip@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2719083002 Cr-Commit-Position: refs/heads/master@{#453277} Committed: https://chromium.googlesource.com/chromium/src/+/6e0dec285733a1c7be98253683d7ed7129290878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
D third_party/WebKit/LayoutTests/external/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
qyearsley
Created Revert of Add dummy file with very long path to test path length limits.
3 years, 9 months ago (2017-02-27 17:42:48 UTC) #1
foolip
lgtm
3 years, 9 months ago (2017-02-27 18:26:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719083002/1
3 years, 9 months ago (2017-02-27 18:51:19 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 19:01:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e0dec285733a1c7be98253683d7...

Powered by Google App Engine
This is Rietveld 408576698