Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2718733002: Add dummy file with very long path to test path length limits. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
tkent, foolip
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dummy file with very long path to test path length limits. This CL adds a path in Chromium with a total length of 204 from the repo root, which would be the length of a file in LayoutTests/external/wpt/<subpath> where <subpath> is 160 characters. So, if this CL doesn't break anything, then http://crrev.com/2708883004 could be committed. This CL might break any builders with a checkout directory of about 43 characters or more. Context: see http://crrev.com/2708883004 Review-Url: https://codereview.chromium.org/2718733002 Cr-Commit-Position: refs/heads/master@{#453109} Committed: https://chromium.googlesource.com/chromium/src/+/ce0805ea777b313eb24184737d2b0dfde45e8c69

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
A third_party/WebKit/LayoutTests/external/xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
qyearsley
3 years, 10 months ago (2017-02-24 19:55:41 UTC) #5
tkent
lgtm
3 years, 10 months ago (2017-02-24 22:49:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718733002/1
3 years, 10 months ago (2017-02-25 23:28:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ce0805ea777b313eb24184737d2b0dfde45e8c69
3 years, 10 months ago (2017-02-26 00:45:39 UTC) #13
qyearsley
3 years, 9 months ago (2017-02-27 17:42:48 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2719083002/ by qyearsley@chromium.org.

The reason for reverting is: (this was a temporary CL to test whether long paths
break things).

Powered by Google App Engine
This is Rietveld 408576698