Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2719003002: Make VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() not to call validate() (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() not to call validate() This patch makes |adjustSelectionToAvoidCrossingEditingBoundaries()| in |VisibleSelection| not to call |validate()| as a preparation of changing a parameter to |SelectionInDOMTree|[1] for improving code health. [1] http://crrev.com/2722523002 Get rid of VisibleSelection::m_granularity and m_hasTrailingWhitespace BUG=513568 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2719003002 Cr-Commit-Position: refs/heads/master@{#453311} Committed: https://chromium.googlesource.com/chromium/src/+/98f81ced0431b88f99df691fa495deaacb0d095d

Patch Set 1 : 2017-02-27T18:16:46 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-02-27 09:22:45 UTC) #5
Xiaocheng
lgtm
3 years, 9 months ago (2017-02-27 19:54:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2719003002/1
3 years, 9 months ago (2017-02-27 19:55:41 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 20:06:08 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/98f81ced0431b88f99df691fa495...

Powered by Google App Engine
This is Rietveld 408576698