Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2719003002: Make VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries() not to call validate() (Closed)
Patch Set: 2017-02-27T18:16:46 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index 32c09d2b5dd99e83ac0eebf4ed0d8239ee842b72..3463cfc1101aa40f0ad40cb9695ad8957f44c7ec 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -650,9 +650,7 @@ void VisibleSelectionTemplate<
// The selection crosses an Editing boundary. This is a
// programmer error in the editing code. Happy debugging!
NOTREACHED();
- m_base = PositionTemplate<Strategy>();
- m_extent = PositionTemplate<Strategy>();
- validate();
+ *this = VisibleSelectionTemplate<Strategy>();
return;
}
m_end = previous.deepEquivalent();
@@ -688,9 +686,7 @@ void VisibleSelectionTemplate<
// The selection crosses an Editing boundary. This is a
// programmer error in the editing code. Happy debugging!
NOTREACHED();
- m_base = PositionTemplate<Strategy>();
- m_extent = PositionTemplate<Strategy>();
- validate();
+ *this = VisibleSelectionTemplate<Strategy>();
return;
}
m_start = next.deepEquivalent();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698