Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 2718703003: Revert of Re-enable media.android.tough_video_cases. (Closed)

Created:
3 years, 10 months ago by watk
Modified:
3 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable media.android.tough_video_cases. (patchset #2 id:20001 of https://codereview.chromium.org/2684033009/ ) Reason for revert: This still fails for the reference build because M56 doesn't have the prerequisite fixes mentioned in the commit message yet. See http://crbug.com/695960 Original issue's description: > Re-enable media.android.tough_video_cases. > > This was disabled in cr/2402083002 and cr/2549373003. > > The problem was that we became idle during seek, so we would suspend if the seek > took too long. sandersd@ fixed this in cr/2490783002. > > liberato@ tested this both right before and right after sandersd@'s > change. Before the change it would usually fail but sometimes succeed. > After the change it would always succeed. > > BUG=647372 > > Review-Url: https://codereview.chromium.org/2684033009 > Cr-Commit-Position: refs/heads/master@{#449538} > Committed: https://chromium.googlesource.com/chromium/src/+/b4f0e124c5a8884a16459c67d956d011be8acc5a TBR=johnchen@chromium.org,liberato@chromium.org,nednguyen@google.com,sullivan@chromium.org,sandersd@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=647372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/perf/benchmarks/media.py View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
watk
Created Revert of Re-enable media.android.tough_video_cases.
3 years, 10 months ago (2017-02-24 21:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718703003/1
3 years, 10 months ago (2017-02-24 21:21:13 UTC) #3
watk
3 years, 10 months ago (2017-02-24 21:26:27 UTC) #5
Actually, not reverting due to an update on the bug from sullivan@:  reference
build failures don't make the perf builds fail so we can leave this enabled and
it will fix itself when 57 becomes the reference.

Powered by Google App Engine
This is Rietveld 408576698