Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: tools/perf/benchmarks/media.py

Issue 2718703003: Revert of Re-enable media.android.tough_video_cases. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from telemetry import benchmark 7 from telemetry import benchmark
8 from telemetry.page import legacy_page_test 8 from telemetry.page import legacy_page_test
9 from telemetry.value import list_of_scalar_values 9 from telemetry.value import list_of_scalar_values
10 from telemetry.value import scalar 10 from telemetry.value import scalar
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 class MediaNetworkSimulation(perf_benchmark.PerfBenchmark): 67 class MediaNetworkSimulation(perf_benchmark.PerfBenchmark):
68 """Obtains media metrics under different network simulations.""" 68 """Obtains media metrics under different network simulations."""
69 test = media.Media 69 test = media.Media
70 page_set = page_sets.MediaCnsCasesPageSet 70 page_set = page_sets.MediaCnsCasesPageSet
71 71
72 @classmethod 72 @classmethod
73 def Name(cls): 73 def Name(cls):
74 return 'media.media_cns_cases' 74 return 'media.media_cns_cases'
75 75
76 76
77 @benchmark.Disabled('l', 'android-webview') # WebView: crbug.com/419689. 77 @benchmark.Disabled('android') # crbug.com/671628, WebView: crbug.com/419689.
78 class MediaAndroid(perf_benchmark.PerfBenchmark): 78 class MediaAndroid(perf_benchmark.PerfBenchmark):
79 """Obtains media metrics for key user scenarios on Android.""" 79 """Obtains media metrics for key user scenarios on Android."""
80 test = media.Media 80 test = media.Media
81 tag = 'android' 81 tag = 'android'
82 page_set = page_sets.ToughVideoCasesPageSet 82 page_set = page_sets.ToughVideoCasesPageSet
83 # Exclude is_4k and 50 fps media files (garden* & crowd*). 83 # Exclude is_4k and 50 fps media files (garden* & crowd*).
84 options = {'story_tag_filter_exclude': 'is_4k,is_50fps'} 84 options = {'story_tag_filter_exclude': 'is_4k,is_50fps'}
85 85
86 @classmethod 86 @classmethod
87 def ShouldDisable(cls, possible_browser): 87 def ShouldDisable(cls, possible_browser):
88 # crbug.com/672059
88 if possible_browser.platform.GetOSName() != "android": 89 if possible_browser.platform.GetOSName() != "android":
89 return True 90 return True
90 return cls.IsSvelte(possible_browser) 91 # crbug.com/448092
92 if cls.IsSvelte(possible_browser):
93 return True
94
95 # crbug.com/647372
96 if possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X':
97 return True
98
99 return False
91 100
92 @classmethod 101 @classmethod
93 def Name(cls): 102 def Name(cls):
94 return 'media.android.tough_video_cases' 103 return 'media.android.tough_video_cases'
95 104
96 105
97 @benchmark.Enabled('chromeos') 106 @benchmark.Enabled('chromeos')
98 class MediaChromeOS4kOnly(perf_benchmark.PerfBenchmark): 107 class MediaChromeOS4kOnly(perf_benchmark.PerfBenchmark):
99 """Benchmark for media performance on ChromeOS using only is_4k test content. 108 """Benchmark for media performance on ChromeOS using only is_4k test content.
100 """ 109 """
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 147
139 @classmethod 148 @classmethod
140 def Name(cls): 149 def Name(cls):
141 return 'media.mse_cases' 150 return 'media.mse_cases'
142 151
143 def SetExtraBrowserOptions(self, options): 152 def SetExtraBrowserOptions(self, options):
144 # Needed to allow XHR requests to return stream objects. 153 # Needed to allow XHR requests to return stream objects.
145 options.AppendExtraBrowserArgs( 154 options.AppendExtraBrowserArgs(
146 ['--enable-experimental-web-platform-features', 155 ['--enable-experimental-web-platform-features',
147 '--disable-gesture-requirement-for-media-playback']) 156 '--disable-gesture-requirement-for-media-playback'])
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698