Re-enable media.android.tough_video_cases.

Re-enable media.android.tough_video_cases.

This was disabled in cr/2402083002 and  cr/2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in cr/2490783002.

liberato@ tested this both right before and right after sandersd@'s 
change. Before the change it would usually fail but sometimes succeed. 
After the change it would always succeed.

BUG=647372
Review-Url: https://codereview.chromium.org/2684033009
Cr-Commit-Position: refs/heads/master@{#449538}
Committed: https://chromium.googlesource.com/chromium/src/+/b4f0e124c5a8884a16459c67d956d011be8acc5a

[CalebRouleau, 2017-02-10 00:21:29]

Description was changed from

==========
Re-enable media.android.tough_video_cases.

This was disabled in issue 2402083002 and issue 2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in issue 2490783002.

BUG=647372
==========

to

==========
Re-enable media.android.tough_video_cases.

This was disabled in issue 2402083002 and issue 2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in issue 2490783002.

BUG=647372
==========

[CalebRouleau, 2017-02-10 00:21:29]

crouleau@chromium.org changed reviewers:
+ johnchen@chromium.org, liberato@chromium.org, nednguyen@google.com,
sullivan@chromium.org

[CalebRouleau, 2017-02-10 00:21:57]

crouleau@chromium.org changed reviewers:
+ sandersd@chromium.org

[CalebRouleau, 2017-02-10 00:23:02]

Description was changed from

==========
Re-enable media.android.tough_video_cases.

This was disabled in issue 2402083002 and issue 2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in issue 2490783002.

BUG=647372
==========

to

==========
Re-enable media.android.tough_video_cases.

This was disabled in cr/2402083002 and  cr/2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in cr/2490783002.

BUG=647372
==========

[CalebRouleau, 2017-02-10 00:24:48]

Description was changed from

==========
Re-enable media.android.tough_video_cases.

This was disabled in cr/2402083002 and  cr/2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in cr/2490783002.

BUG=647372
==========

to

==========
Re-enable media.android.tough_video_cases.

This was disabled in cr/2402083002 and  cr/2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in cr/2490783002.

liberato@ tested this both right before and right after sandersd@'s change.
Before the change it would usually fail but sometimes succeed. After the change
it would always succeed.

BUG=647372
==========

[CalebRouleau, 2017-02-10 00:25:04]

Description was changed from

==========
Re-enable media.android.tough_video_cases.

This was disabled in cr/2402083002 and  cr/2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in cr/2490783002.

liberato@ tested this both right before and right after sandersd@'s change.
Before the change it would usually fail but sometimes succeed. After the change
it would always succeed.

BUG=647372
==========

to

==========
Re-enable media.android.tough_video_cases.

This was disabled in cr/2402083002 and  cr/2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in cr/2490783002.

liberato@ tested this both right before and right after sandersd@'s 
change. Before the change it would usually fail but sometimes succeed. 
After the change it would always succeed.

BUG=647372
==========

[nednguyen, 2017-02-10 00:31:58]

lgtm

[johnchen, 2017-02-10 01:46:36]

https://codereview.chromium.org/2684033009/diff/1/tools/perf/benchmarks/media.py
File tools/perf/benchmarks/media.py (left):

https://codereview.chromium.org/2684033009/diff/1/tools/perf/benchmarks/media...
tools/perf/benchmarks/media.py:89: if possible_browser.platform.GetOSName() !=
"android":
Offline comment

[CalebRouleau, 2017-02-10 01:52:15]

On 2017/02/10 01:46:36, johnchen wrote:
>
https://codereview.chromium.org/2684033009/diff/1/tools/perf/benchmarks/media.py
> File tools/perf/benchmarks/media.py (left):
> 
>
https://codereview.chromium.org/2684033009/diff/1/tools/perf/benchmarks/media...
> tools/perf/benchmarks/media.py:89: if possible_browser.platform.GetOSName() !=
> "android":
> Offline comment

Thanks John!

John noticed that this CL would have enabled the test to run on desktop OSes as
well. That should be fixed now.

[johnchen, 2017-02-10 01:54:25]

On 2017/02/10 01:52:15, crouleau wrote:
> On 2017/02/10 01:46:36, johnchen wrote:
> >
>
https://codereview.chromium.org/2684033009/diff/1/tools/perf/benchmarks/media.py
> > File tools/perf/benchmarks/media.py (left):
> > 
> >
>
https://codereview.chromium.org/2684033009/diff/1/tools/perf/benchmarks/media...
> > tools/perf/benchmarks/media.py:89: if possible_browser.platform.GetOSName()
!=
> > "android":
> > Offline comment
> 
> Thanks John!
> 
> John noticed that this CL would have enabled the test to run on desktop OSes
as
> well. That should be fixed now.

LGTM

[CalebRouleau, 2017-02-10 01:56:51]

On 2017/02/10 01:52:15, crouleau wrote:
> On 2017/02/10 01:46:36, johnchen wrote:
> >
>
https://codereview.chromium.org/2684033009/diff/1/tools/perf/benchmarks/media.py
> > File tools/perf/benchmarks/media.py (left):
> > 
> >
>
https://codereview.chromium.org/2684033009/diff/1/tools/perf/benchmarks/media...
> > tools/perf/benchmarks/media.py:89: if possible_browser.platform.GetOSName()
!=
> > "android":
> > Offline comment
> 
> Thanks John!
> 
> John noticed that this CL would have enabled the test to run on desktop OSes
as
> well. That should be fixed now.

I verified that it is fixed now: 

tools/perf/run_benchmark --browser=stable media.android.tough_video_cases
WARNING:root:Chrome build location for linux_x86_64 not found. Browser will be
run without Flash.
WARNING:root:Chrome build location for linux_x86_64 not found. Browser will be
run without Flash.
media.android.tough_video_cases is disabled on the selected browser
Try --also-run-disabled-tests to force the benchmark to run.

[CalebRouleau, 2017-02-10 01:57:27]

The CQ bit was checked by crouleau@chromium.org

[CalebRouleau, 2017-02-10 01:57:27]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2684033009/#ps20001
(title: "Fixed so it only runs on Android. Thanks johnchen@!")

[commit-bot: I haz the power, 2017-02-10 01:57:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:56:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486691847097350,
"parent_rev": "839c0febbdfdef7007e693daae6a3504a2b1c3cc", "commit_rev":
"b4f0e124c5a8884a16459c67d956d011be8acc5a"}

[commit-bot: I haz the power, 2017-02-10 02:56:54]

Description was changed from

==========
Re-enable media.android.tough_video_cases.

This was disabled in cr/2402083002 and  cr/2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in cr/2490783002.

liberato@ tested this both right before and right after sandersd@'s 
change. Before the change it would usually fail but sometimes succeed. 
After the change it would always succeed.

BUG=647372
==========

to

==========
Re-enable media.android.tough_video_cases.

This was disabled in cr/2402083002 and  cr/2549373003.

The problem was that we became idle during seek, so we would suspend if the seek
took too long. sandersd@ fixed this in cr/2490783002.

liberato@ tested this both right before and right after sandersd@'s 
change. Before the change it would usually fail but sometimes succeed. 
After the change it would always succeed.

BUG=647372

Review-Url: https://codereview.chromium.org/2684033009
Cr-Commit-Position: refs/heads/master@{#449538}
Committed:
https://chromium.googlesource.com/chromium/src/+/b4f0e124c5a8884a16459c67d956...
==========

[commit-bot: I haz the power, 2017-02-10 02:56:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b4f0e124c5a8884a16459c67d956...

[watk, 2017-02-24 21:20:30]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2718703003/ by watk@chromium.org.

The reason for reverting is: This still fails for the reference build because
M56 doesn't have the prerequisite fixes mentioned in the commit message yet. See
http://crbug.com/695960.