Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp

Issue 2718643002: Worker: Pass ParentFrameTaskRunners via WorkerThread::start() instead of the ctor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
index a4ebe7e1b948062d7f3904388671622056eec919..6598af7b041e9cb5abafa1252a6996dcb52acc7a 100644
--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp
@@ -108,16 +108,17 @@ class CompositorWorkerThreadTest : public ::testing::Test {
std::unique_ptr<CompositorWorkerThread> createCompositorWorker() {
std::unique_ptr<CompositorWorkerThread> workerThread =
- CompositorWorkerThread::create(nullptr, *m_objectProxy,
- m_parentFrameTaskRunners.get(), 0);
+ CompositorWorkerThread::create(nullptr, *m_objectProxy, 0);
WorkerClients* clients = WorkerClients::create();
provideCompositorWorkerProxyClientTo(clients,
new TestCompositorWorkerProxyClient);
- workerThread->start(WorkerThreadStartupData::create(
- KURL(ParsedURLString, "http://fake.url/"), "fake user agent",
- "//fake source code", nullptr, DontPauseWorkerGlobalScopeOnStart,
- nullptr, "", m_securityOrigin.get(), clients, WebAddressSpaceLocal,
- nullptr, nullptr, WorkerV8Settings::Default()));
+ workerThread->start(
+ WorkerThreadStartupData::create(
+ KURL(ParsedURLString, "http://fake.url/"), "fake user agent",
+ "//fake source code", nullptr, DontPauseWorkerGlobalScopeOnStart,
+ nullptr, "", m_securityOrigin.get(), clients, WebAddressSpaceLocal,
+ nullptr, nullptr, WorkerV8Settings::Default()),
+ m_parentFrameTaskRunners.get());
return workerThread;
}

Powered by Google App Engine
This is Rietveld 408576698