Convert more ScriptProcessorNode tests to testharness

Convert more ScriptProcessorNode tests to testharness

Manually converted these tests to use testharness and new Audit.

Note that resources/scriptprocessornode-testing-audit.js was added to
allow converting tests that use runJSNodeTest to use new audit.
However, scriptprocessornode-rewrap.html, which also uses
runJSNodeTest, wasn't converted to testharness because it's not clear
what exactly is supposed to happen and whether converting to
testharness and audit will preserve behavior.

BUG=688493
TEST=scriptprocessornode.html,
scriptprocessornode-downmix8-2channel-input.html,
scriptprocessornode-upmix2-8channel-input.html,
scriptprocessornode-zero-input-channels.html

Review-Url: https://codereview.chromium.org/2718563004
Cr-Commit-Position: refs/heads/master@{#453717}
Committed: https://chromium.googlesource.com/chromium/src/+/3278631c5f14a11be76ad06b91e3125343345cc7

[Raymond Toy, 2017-02-24 16:24:42]

Description was changed from

==========
Convert more ScriptProcessorNode tests to testharness

Manually converted these tests to use testharness and new Audit.

Note that resources/scriptprocessornode-testing-audit.js was added to
allow converting tests that use runJSNodeTest to use new audit.
However, scriptprocessornode-rewrap.html, which also uses
runJSNodeTest, wasn't converted to testharness because it's not clear
what exactly is supposed to happen and whether converting to
testharness and audit will preserve behavior.

BUG=688493
TEST=
==========

to

==========
Convert more ScriptProcessorNode tests to testharness

Manually converted these tests to use testharness and new Audit.

Note that resources/scriptprocessornode-testing-audit.js was added to
allow converting tests that use runJSNodeTest to use new audit.
However, scriptprocessornode-rewrap.html, which also uses
runJSNodeTest, wasn't converted to testharness because it's not clear
what exactly is supposed to happen and whether converting to
testharness and audit will preserve behavior.

BUG=688493
TEST=scriptprocessornode.html,
scriptprocessornode-downmix8-2channel-input.html,
scriptprocessornode-upmix2-8channel-input.html,
scriptprocessornode-zero-input-channels.html
==========

[Raymond Toy, 2017-02-24 16:25:23]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-24 16:25:23]

PTAL

[hongchan, 2017-02-24 23:12:47]

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html:25:
'downmixing an 8-channel source connected to a JavaScriptAudioNode with
2-channel input'
This needs to be wrapped.

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input.html:25:
'upmixing a 2-channel source connected to a JavaScriptAudioNode with 8-channel
input'
Ditto.

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html:20:
task.done();
These two lines can go into the line 51. Then we can remove checkResult()
function.

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode.html:22:
// bufferSize to have exactly the same value to avoid this issue.
This is not true anymore. Now we have suspend/resume on OAC and synchronous
offline rendering with SPN. I think we can significantly simplify these tests by
reducing the scope.

Or not - we can just save our effort by doing nothing for SPN.

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode.html:76:
{label: 'test', description: 'Basic ScriptProcessorNode properties'},
A space needed after the beginning curly brace and before the ending one.

{ /* content */ }

Surprised clang-format didn't catch this.

[Raymond Toy, 2017-02-24 23:18:10]

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html:25:
'downmixing an 8-channel source connected to a JavaScriptAudioNode with
2-channel input'
On 2017/02/24 23:12:46, hongchan wrote:
> This needs to be wrapped.

By doing '...' + '...'?

BTW, clang-format left it this way

[hongchan, 2017-02-24 23:42:46]

It would be better for us to remove some redundant tests for SPN.

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html:25:
'downmixing an 8-channel source connected to a JavaScriptAudioNode with
2-channel input'
On 2017/02/24 23:18:10, Raymond Toy wrote:
> On 2017/02/24 23:12:46, hongchan wrote:
> > This needs to be wrapped.
> 
> By doing '...' + '...'?
> 
> BTW, clang-format left it this way

I would try rephrase it first, and use '+' to break the string down if that
doesn't work out.

[Raymond Toy, 2017-02-27 17:23:40]

On 2017/02/24 23:42:46, hongchan wrote:
> It would be better for us to remove some redundant tests for SPN.

I agree in general, but on closer examination, I think the mixing tests are
valid.  Unlike other nodes, the mixing internals aren't exposed.  But for the
SPN, the mixing of the input is shows up in the onaudioprocess that the user
must write.  Similarly, the mixing of the output is exposed because the the
output data from the user must be mixed for the final output of the SPN.


> 
>
https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html
> (right):
> 
>
https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html:25:
> 'downmixing an 8-channel source connected to a JavaScriptAudioNode with
> 2-channel input'
> On 2017/02/24 23:18:10, Raymond Toy wrote:
> > On 2017/02/24 23:12:46, hongchan wrote:
> > > This needs to be wrapped.
> > 
> > By doing '...' + '...'?
> > 
> > BTW, clang-format left it this way
> 
> I would try rephrase it first, and use '+' to break the string down if that
> doesn't work out.

[Raymond Toy, 2017-02-27 17:31:22]

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html:25:
'downmixing an 8-channel source connected to a JavaScriptAudioNode with
2-channel input'
On 2017/02/24 23:42:46, hongchan wrote:
> On 2017/02/24 23:18:10, Raymond Toy wrote:
> > On 2017/02/24 23:12:46, hongchan wrote:
> > > This needs to be wrapped.
> > 
> > By doing '...' + '...'?
> > 
> > BTW, clang-format left it this way
> 
> I would try rephrase it first, and use '+' to break the string down if that
> doesn't work out.

Done.

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input.html:25:
'upmixing a 2-channel source connected to a JavaScriptAudioNode with 8-channel
input'
On 2017/02/24 23:12:46, hongchan wrote:
> Ditto.

Done.

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html
(right):

https://codereview.chromium.org/2718563004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html:20:
task.done();
On 2017/02/24 23:12:46, hongchan wrote:
> These two lines can go into the line 51. Then we can remove checkResult()
> function.

Done.

[hongchan, 2017-02-27 18:16:12]

https://codereview.chromium.org/2718563004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html
(right):

https://codereview.chromium.org/2718563004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html:49:
;
A lonely semicolon.

https://codereview.chromium.org/2718563004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/resources/scriptprocessornode-testing-audit.js
(right):

https://codereview.chromium.org/2718563004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/scriptprocessornode-testing-audit.js:1:
// For the current implementation of JavaScriptAudioNode, when it works with
OfflineAudioContext (which runs much faster
This file is newly created. Perhaps apply clang-format and be done with it?

[Raymond Toy, 2017-02-27 19:07:34]

https://codereview.chromium.org/2718563004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/webaudio/resources/scriptprocessornode-testing-audit.js
(right):

https://codereview.chromium.org/2718563004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/scriptprocessornode-testing-audit.js:1:
// For the current implementation of JavaScriptAudioNode, when it works with
OfflineAudioContext (which runs much faster
On 2017/02/27 18:16:12, hongchan wrote:
> This file is newly created. Perhaps apply clang-format and be done with it?

Done, and also changed var to let.

[hongchan, 2017-02-28 17:43:57]

lgtm

[Raymond Toy, 2017-02-28 19:27:49]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-02-28 19:28:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 22:05:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488310069241520,
"parent_rev": "c42114c9b3b7bb61deab9879e8b2abe9f4626ef1", "commit_rev":
"3278631c5f14a11be76ad06b91e3125343345cc7"}

[commit-bot: I haz the power, 2017-02-28 22:06:37]

Description was changed from

==========
Convert more ScriptProcessorNode tests to testharness

Manually converted these tests to use testharness and new Audit.

Note that resources/scriptprocessornode-testing-audit.js was added to
allow converting tests that use runJSNodeTest to use new audit.
However, scriptprocessornode-rewrap.html, which also uses
runJSNodeTest, wasn't converted to testharness because it's not clear
what exactly is supposed to happen and whether converting to
testharness and audit will preserve behavior.

BUG=688493
TEST=scriptprocessornode.html,
scriptprocessornode-downmix8-2channel-input.html,
scriptprocessornode-upmix2-8channel-input.html,
scriptprocessornode-zero-input-channels.html
==========

to

==========
Convert more ScriptProcessorNode tests to testharness

Manually converted these tests to use testharness and new Audit.

Note that resources/scriptprocessornode-testing-audit.js was added to
allow converting tests that use runJSNodeTest to use new audit.
However, scriptprocessornode-rewrap.html, which also uses
runJSNodeTest, wasn't converted to testharness because it's not clear
what exactly is supposed to happen and whether converting to
testharness and audit will preserve behavior.

BUG=688493
TEST=scriptprocessornode.html,
scriptprocessornode-downmix8-2channel-input.html,
scriptprocessornode-upmix2-8channel-input.html,
scriptprocessornode-zero-input-channels.html

Review-Url: https://codereview.chromium.org/2718563004
Cr-Commit-Position: refs/heads/master@{#453717}
Committed:
https://chromium.googlesource.com/chromium/src/+/3278631c5f14a11be76ad06b91e3...
==========

[commit-bot: I haz the power, 2017-02-28 22:06:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3278631c5f14a11be76ad06b91e3...