Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html

Issue 2718563004: Convert more ScriptProcessorNode tests to testharness (Closed)
Patch Set: Address review comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html b/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html
index 4a05ed9321a2dd9595529546c5bf296e9abbf443..c1af136fb0054466524b56629ae3ab0b07b498a3 100644
--- a/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html
+++ b/third_party/WebKit/LayoutTests/webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html
@@ -1,67 +1,56 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
-<script src="../../resources/js-test.js"></script>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
<script src="../resources/audit-util.js"></script>
-<script src="../resources/audio-testing.js"></script>
+<script src="../resources/audit.js"></script>
</head>
<body>
-<div id="description"></div>
-<div id="console"></div>
-
<script>
-description("Tests that ScriptProcessorNode accepts 0 input channels.");
-
-var sampleRate = 44100.0;
-var renderLengthInFrames = 512;
-var bufferSize = 512;
-
-function checkResult(e)
-{
- testPassed("ScriptProcessorNode accepts 0 input channels.");
-
- finishJSTest();
-}
-
-function runTest()
-{
- if (window.testRunner) {
- testRunner.dumpAsText();
- testRunner.waitUntilDone();
- }
+let audit = Audit.createTaskRunner();
- window.jsTestIsAsync = true;
+let sampleRate = 44100.0;
+let renderLengthInFrames = 512;
+let bufferSize = 512;
- var context = new OfflineAudioContext(1, renderLengthInFrames, sampleRate);
+audit.define(
+ {
+ label: 'test',
+ description: 'Tests that ScriptProcessorNode accepts 0 input channels'
+ },
+ (task, should) => {
+ let context =
+ new OfflineAudioContext(1, renderLengthInFrames, sampleRate);
- var node;
+ let node;
- try {
+ should(() => {
node = context.createScriptProcessor(bufferSize, 0, 1);
- testPassed("Successfully created ScriptProcessorNode.");
- } catch (e) {
- testFailed("Failed to create ScriptProcessorNode.");
- }
-
- var source = context.createBufferSource();
- source.buffer = createImpulseBuffer(context, bufferSize);
-
- // The onaudioprocess function doesn't need to do anything. We just need the process to start
- // to test that implementation accepts 0 input channels.
- //
- // FIXME: check the .inputBuffer attribute of the AudioProcessingEvent.
- node.onaudioprocess = function(e) { };
- source.connect(node);
- node.connect(context.destination);
- source.start(0);
-
- context.oncomplete = checkResult;
- context.startRendering();
-}
-
-runTest();
-successfullyParsed = true;
+ }, 'node = context.createScriptProcessor(bufferSize, 0, 1)').notThrow();
+ let source = context.createBufferSource();
+ source.buffer = createImpulseBuffer(context, bufferSize);
+
+ // The onaudioprocess function doesn't need to do anything. We just need
+ // the process to start to test that implementation accepts 0 input
+ // channels.
+ //
+ // FIXME: check the .inputBuffer attribute of the AudioProcessingEvent.
+ node.onaudioprocess = function(e) {};
+ source.connect(node);
+ node.connect(context.destination);
+ source.start(0);
+
+ context.oncomplete = event => {
+ should(true, 'ScriptProcessorNode accepts 0 input channels').beTrue();
+ task.done();
+ };
+
+ context.startRendering();
+ });
+
+audit.run();
</script>
</body>

Powered by Google App Engine
This is Rietveld 408576698