Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2718503004: Remove Rietveld class and all dependencies on it. (Closed)

Created:
3 years, 10 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
wkorman, foolip
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, foolip, jeffcarp, net-reviews_chromium.org, tfarina, tkent
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Rietveld class and all dependencies on it. This CL depends on (includes) http://crrev.com/2715803002, a smaller change which could be submitted first. BUG=693792 Review-Url: https://codereview.chromium.org/2718503004 Cr-Commit-Position: refs/heads/master@{#452927} Committed: https://chromium.googlesource.com/chromium/src/+/4f81759ab3dbfb493d2d7d849785b3df6dc257af

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -223 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl.py View 1 chunk +1 line, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/git_cl_unittest.py View 1 chunk +3 lines, -12 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py View 1 chunk +0 lines, -100 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py View 1 chunk +0 lines, -95 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
qyearsley
Adding Walter as reviewer since Walter reviewed the original change which added rietveld.py, and the ...
3 years, 10 months ago (2017-02-23 23:00:57 UTC) #5
foolip
Cool, can we start using Gerrit right now even before it's the default review system?
3 years, 10 months ago (2017-02-24 04:28:19 UTC) #9
qyearsley
On 2017/02/24 at 04:28:19, foolip wrote: > Cool, can we start using Gerrit right now ...
3 years, 10 months ago (2017-02-24 18:34:56 UTC) #10
wkorman
lgtm
3 years, 10 months ago (2017-02-24 18:37:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718503004/20001
3 years, 10 months ago (2017-02-24 19:53:23 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 21:27:37 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4f81759ab3dbfb493d2d7d849785...

Powered by Google App Engine
This is Rietveld 408576698