third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py - Issue 2718503004: Remove Rietveld class and all dependencies on it.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py

Issue 2718503004: Remove Rietveld class and all dependencies on it. (Closed)

Patch Set: Rebased Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py ('k') | no next file » | no next file with comments »

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import copy	5 import copy

6	6

7 from webkitpy.common.host_mock import MockHost	7 from webkitpy.common.host_mock import MockHost

8 from webkitpy.common.net.buildbot import Build	8 from webkitpy.common.net.buildbot import Build

9 from webkitpy.common.net.buildbot_mock import MockBuildBot	9 from webkitpy.common.net.buildbot_mock import MockBuildBot

10 from webkitpy.common.net.layout_test_results import LayoutTestResult, LayoutTest Results	10 from webkitpy.common.net.layout_test_results import LayoutTestResult, LayoutTest Results

(...skipping 408 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
419	419

420 def test_run_no_issue_number(self):	420 def test_run_no_issue_number(self):

421 # TODO(qyearsley): For testing: Consider making a MockGitCL class	421 # TODO(qyearsley): For testing: Consider making a MockGitCL class

422 # and use that class to set fake return values when using git cl.	422 # and use that class to set fake return values when using git cl.

423 updater = WPTExpectationsUpdater(self.mock_host())	423 updater = WPTExpectationsUpdater(self.mock_host())

424 updater.get_issue_number = lambda: 'None'	424 updater.get_issue_number = lambda: 'None'

425 self.assertEqual(1, updater.run(args=[]))	425 self.assertEqual(1, updater.run(args=[]))

426 self.assertLog(['ERROR: No issue on current branch.\n'])	426 self.assertLog(['ERROR: No issue on current branch.\n'])

427	427

428 def test_run_no_try_results(self):	428 def test_run_no_try_results(self):

429 host = self.mock_host()	429 updater = WPTExpectationsUpdater(self.mock_host())

430 updater = WPTExpectationsUpdater(host)

431 updater.get_latest_try_jobs = lambda: []	430 updater.get_latest_try_jobs = lambda: []

432 self.assertEqual(1, updater.run(args=[]))	431 self.assertEqual(1, updater.run(args=[]))

433 self.assertLog(['ERROR: No try job information was collected.\n'])	432 self.assertLog(['ERROR: No try job information was collected.\n'])

OLD	NEW