Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2718433002: MIPS64: Fix corner case for Word64And(Word64Shr(val,0)) reduction (Closed)

Created:
3 years, 10 months ago by ivica.bogosavljevic
Modified:
3 years, 10 months ago
Reviewers:
miran.karic, miran.karic
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix corner case for Word64And(Word64Shr(val,0)) reduction In instruction selector, in the reduction of Word64And(Word64Shr(val,0), 0xFFF...) to EXT instruction, the case where shift value is 0 and mask is 0xFFFFFFFFFFFFFFFF was not supported. We now generate NOP for this case since no bit extraction is necessary. We implement the same behavior for MIPS32 even though there are no tests that are failing. TEST=cctest/test-run-machops/Regression5951 BUG= Review-Url: https://codereview.chromium.org/2718433002 Cr-Commit-Position: refs/heads/master@{#43408} Committed: https://chromium.googlesource.com/v8/v8/+/5b8f1f84a4316da06103fab2d970f05d14e45993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
ivica.bogosavljevic
PTAL
3 years, 10 months ago (2017-02-23 11:02:44 UTC) #2
miran.karic
lgtm
3 years, 10 months ago (2017-02-23 12:50:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718433002/1
3 years, 10 months ago (2017-02-24 09:35:55 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 09:58:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5b8f1f84a4316da06103fab2d970f05d14e...

Powered by Google App Engine
This is Rietveld 408576698