Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2718373003: Revert of Fix a notification update issue when navigating to a different URL in the same origin (Closed)

Created:
3 years, 9 months ago by Zhiqiang Zhang (Slow)
Modified:
3 years, 9 months ago
Reviewers:
whywhat
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix a notification update issue when navigating to a different URL in the same origin (patchset #2 id:20001 of https://codereview.chromium.org/2720073002/ ) Reason for revert: The CL is an incomplete fix, as there's another underlying issue in MediaSessionServiceImpl wrt RenderFrame loading. Original issue's description: > Fix a notification update issue when navigating to a different URL in the same origin > > We should reset the notification info for all non-in-page navigation. > > BUG=696716 > > Review-Url: https://codereview.chromium.org/2720073002 > Cr-Commit-Position: refs/heads/master@{#453573} > Committed: https://chromium.googlesource.com/chromium/src/+/7ed877a5634408b1b4c5791f57ad7ffbfc03d13f TBR=avayvod@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=696716 Review-Url: https://codereview.chromium.org/2718373003 Cr-Commit-Position: refs/heads/master@{#453607} Committed: https://chromium.googlesource.com/chromium/src/+/bc96964f1e70347ca4e9b4b470c101a49033c3fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -45 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationActionsUpdatedTest.java View 4 chunks +2 lines, -13 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java View 4 chunks +7 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Zhiqiang Zhang (Slow)
Created Revert of Fix a notification update issue when navigating to a different URL in ...
3 years, 9 months ago (2017-02-28 15:39:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718373003/1
3 years, 9 months ago (2017-02-28 15:39:55 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 15:41:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bc96964f1e70347ca4e9b4b470c1...

Powered by Google App Engine
This is Rietveld 408576698