Fix a notification update issue when navigating to a different URL in the same origin

Fix a notification update issue when navigating to a different URL in the same origin

We should reset the notification info for all non-in-page navigation.

BUG=696716
Review-Url: https://codereview.chromium.org/2720073002
Cr-Commit-Position: refs/heads/master@{#453573}
Committed: https://chromium.googlesource.com/chromium/src/+/7ed877a5634408b1b4c5791f57ad7ffbfc03d13f

[Zhiqiang Zhang (Slow), 2017-02-27 21:09:19]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-27 21:09:20]

PTAL

[whywhat, 2017-02-27 21:14:21]

lgtm

https://codereview.chromium.org/2720073002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
(left):

https://codereview.chromium.org/2720073002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java:303:
if (mOrigin != null && mOrigin.equals(origin)) return;
perhaps you do need to return early if the origin and other things are the same
so you don't update the notification still?

[Zhiqiang Zhang (Slow), 2017-02-27 21:20:33]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-27 21:20:34]

https://codereview.chromium.org/2720073002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
(left):

https://codereview.chromium.org/2720073002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java:303:
if (mOrigin != null && mOrigin.equals(origin)) return;
On 2017/02/27 at 21:14:21, whywhat wrote:
> perhaps you do need to return early if the origin and other things are the
same so you don't update the notification still?

No, I can't as the new MediaImage and MediaMetadata are unavailable at this
point.

[commit-bot: I haz the power, 2017-02-27 21:21:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 23:26:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 23:26:47]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Zhiqiang Zhang (Slow), 2017-02-28 11:33:30]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2017-02-28 11:33:30]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2720073002/#ps20001
(title: "fixed the URL and in-page navigation in tests")

[commit-bot: I haz the power, 2017-02-28 11:33:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 12:08:01]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488281610193640,
"parent_rev": "1ffffb4de5e00f7cf4d45bb051715892ab621d18", "commit_rev":
"7ed877a5634408b1b4c5791f57ad7ffbfc03d13f"}

[commit-bot: I haz the power, 2017-02-28 12:08:41]

Description was changed from

==========
Fix a notification update issue when navigating to a different URL in the same
origin

We should reset the notification info for all non-in-page navigation.

BUG=696716
==========

to

==========
Fix a notification update issue when navigating to a different URL in the same
origin

We should reset the notification info for all non-in-page navigation.

BUG=696716

Review-Url: https://codereview.chromium.org/2720073002
Cr-Commit-Position: refs/heads/master@{#453573}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ed877a5634408b1b4c5791f57ad...
==========

[commit-bot: I haz the power, 2017-02-28 12:08:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7ed877a5634408b1b4c5791f57ad...

[Zhiqiang Zhang (Slow), 2017-02-28 15:39:34]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2718373003/ by zqzhang@chromium.org.

The reason for reverting is: The CL is an incomplete fix, as there's another
underlying issue in MediaSessionServiceImpl wrt RenderFrame loading..