Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2718313002: Removed FrameHost::pageScaleConstraintsSet() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, kenneth.christiansen, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed FrameHost::pageScaleConstraintsSet() This is part of the work to merge FrameHost back into Page. BUG=691794 Review-Url: https://codereview.chromium.org/2718313002 Cr-Commit-Position: refs/heads/master@{#455360} Committed: https://chromium.googlesource.com/chromium/src/+/5f2871f61b5280b0f20d80aedd47bd8dbd04695d

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 32 (22 generated)
sashab
3 years, 9 months ago (2017-02-28 06:06:08 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-02-28 06:33:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718313002/20001
3 years, 9 months ago (2017-03-06 23:33:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/378883)
3 years, 9 months ago (2017-03-07 02:01:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718313002/20001
3 years, 9 months ago (2017-03-07 02:12:18 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/395299)
3 years, 9 months ago (2017-03-07 04:53:05 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718313002/40001
3 years, 9 months ago (2017-03-07 05:03:26 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/379304)
3 years, 9 months ago (2017-03-07 07:57:12 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2718313002/40001
3 years, 9 months ago (2017-03-08 01:03:31 UTC) #29
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 03:03:51 UTC) #32
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5f2871f61b5280b0f20d80aedd47...

Powered by Google App Engine
This is Rietveld 408576698