Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 27181005: Fail out of WASAPI render loop when errors are encountered. (Closed)

Created:
7 years, 2 months ago by DaleCurtis
Modified:
7 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fail out of WASAPI render loop when errors are encountered. BUG=none TEST=audio plays Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229667

Patch Set 1 : Rebase. #

Patch Set 2 : Fix signature. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M media/audio/win/audio_low_latency_output_win.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 6 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
DaleCurtis
Should these be fatal errors Henrik?
7 years, 2 months ago (2013-10-15 00:41:05 UTC) #1
henrika (OOO until Aug 14)
Seems like a very reasonable and useful patch. Thanks. LGTM
7 years, 2 months ago (2013-10-15 08:42:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/27181005/4001
7 years, 2 months ago (2013-10-16 06:10:17 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-16 07:15:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/27181005/31001
7 years, 2 months ago (2013-10-19 00:37:52 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=90749
7 years, 2 months ago (2013-10-19 13:49:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/27181005/31001
7 years, 2 months ago (2013-10-19 20:04:03 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-20 05:59:08 UTC) #8
Message was sent while issue was closed.
Change committed as 229667

Powered by Google App Engine
This is Rietveld 408576698