ui: Add gfx::BufferUsage::SCANOUT_CPU_READ_WRITE.

ui: Add gfx::BufferUsage::SCANOUT_CPU_READ_WRITE.

This adds a buffer usage type that can be used to allocate
buffers for scanout and CPU access without turning on support
for native GMBs in general.

Low-latency laser pointer depends on this.

BUG=696384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2717963002
Cr-Commit-Position: refs/heads/master@{#453477}
Committed: https://chromium.googlesource.com/chromium/src/+/d492a16c9bbbe163d48cb0b2976304787f21c5d1

[reveman, 2017-02-27 02:55:27]

Description was changed from

==========
ui: Add gfx::BufferUsage::SCANOUT_CPU_READ_WRITE.

This adds a buffer usage type that can be used to allocate
buffers for scanout and CPU access without turning on support
for native GMBs in general.

Low-latency laser pointer depends on this.

BUG=696384
==========

to

==========
ui: Add gfx::BufferUsage::SCANOUT_CPU_READ_WRITE.

This adds a buffer usage type that can be used to allocate
buffers for scanout and CPU access without turning on support
for native GMBs in general.

Low-latency laser pointer depends on this.

BUG=696384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[reveman, 2017-02-27 02:55:38]

reveman@chromium.org changed reviewers:
+ dcastagna@chromium.org

[Daniele Castagna, 2017-02-27 03:32:05]

lgtm

[reveman, 2017-02-27 11:55:38]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 11:55:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reveman, 2017-02-27 11:57:40]

reveman@chromium.org changed reviewers:
+ avi@chromium.org, dcheng@chromium.org, dnicoara@chromium.org

[reveman, 2017-02-27 11:57:40]

+dnicoara for ui/ozone/platform/drm/
+avi for content/browser/gpu/gpu_internals_ui.cc
+dcheng for ui/gfx/mojo/buffer_types_struct_traits.h

[commit-bot: I haz the power, 2017-02-27 13:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 13:08:39]

Dry run: This issue passed the CQ dry run.

[dnicoara, 2017-02-27 15:16:59]

lgtm

[Avi (use Gerrit), 2017-02-27 15:18:35]

content lgtm

[dcheng, 2017-02-27 23:14:57]

https://codereview.chromium.org/2717963002/diff/1/ui/ozone/platform/drm/clien...
File ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc (right):

https://codereview.chromium.org/2717963002/diff/1/ui/ozone/platform/drm/clien...
ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc:90: case
gfx::BufferUsage::SCANOUT_CPU_READ_WRITE:
Quick question: are these only supposed to be used on CrOS?

[reveman, 2017-02-27 23:47:23]

https://codereview.chromium.org/2717963002/diff/1/ui/ozone/platform/drm/clien...
File ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc (right):

https://codereview.chromium.org/2717963002/diff/1/ui/ozone/platform/drm/clien...
ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc:90: case
gfx::BufferUsage::SCANOUT_CPU_READ_WRITE:
On 2017/02/27 at 23:14:56, dcheng wrote:
> Quick question: are these only supposed to be used on CrOS?

They can be used on other platforms too. The scanout ones might not make as much
sense on other platforms today but they should still work.

[dcheng, 2017-02-27 23:53:22]

lgtm

[reveman, 2017-02-28 01:37:48]

The CQ bit was checked by reveman@chromium.org

[reveman, 2017-02-28 01:37:48]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org,
dcastagna@chromium.org, dnicoara@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2717963002/#ps20001
(title: "SCANOUT_CPU_READ_WRITE as valid shm usage")

[commit-bot: I haz the power, 2017-02-28 01:38:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 02:52:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488245868030340,
"parent_rev": "b95cf280873664a44297368676ff589721ddb6f2", "commit_rev":
"d492a16c9bbbe163d48cb0b2976304787f21c5d1"}

[commit-bot: I haz the power, 2017-02-28 02:53:19]

Description was changed from

==========
ui: Add gfx::BufferUsage::SCANOUT_CPU_READ_WRITE.

This adds a buffer usage type that can be used to allocate
buffers for scanout and CPU access without turning on support
for native GMBs in general.

Low-latency laser pointer depends on this.

BUG=696384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
ui: Add gfx::BufferUsage::SCANOUT_CPU_READ_WRITE.

This adds a buffer usage type that can be used to allocate
buffers for scanout and CPU access without turning on support
for native GMBs in general.

Low-latency laser pointer depends on this.

BUG=696384
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2717963002
Cr-Commit-Position: refs/heads/master@{#453477}
Committed:
https://chromium.googlesource.com/chromium/src/+/d492a16c9bbbe163d48cb0b29763...
==========

[commit-bot: I haz the power, 2017-02-28 02:53:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d492a16c9bbbe163d48cb0b29763...