net/nqe/network_quality_estimator.cc - Issue 2717883002: Make kbps optional when computing effective connection type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/nqe/network_quality_estimator.cc

Issue 2717883002: Make kbps optional when computing effective connection type (Closed)

Patch Set: ps Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/nqe/network_quality_estimator.cc

diff --git a/net/nqe/network_quality_estimator.cc b/net/nqe/network_quality_estimator.cc

index cd3dc1c2c5b0e9d63456537d91e4014209c3b728..cc8428189ec18610cc17bb7174a02a74054882c3 100644

--- a/net/nqe/network_quality_estimator.cc

+++ b/net/nqe/network_quality_estimator.cc

@@ -1101,7 +1101,7 @@ NetworkQualityEstimator::GetRecentEffectiveConnectionTypeAndNetworkQuality(

NetworkQualityEstimator::MetricUsage::

DO_NOT_USE /* transport_rtt_metric */,

NetworkQualityEstimator::MetricUsage::

- MUST_BE_USED /* downstream_throughput_kbps_metric */,

+ USE_IF_AVAILABLE /* downstream_throughput_kbps_metric */,

http_rtt, transport_rtt, downstream_throughput_kbps);

}

if (effective_connection_type_algorithm_ ==

« no previous file with comments | « no previous file | no next file » | no next file with comments »