Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2717773002:
[test262] skip two Intl.NumberFormat tests (Closed)
Description[test262] skip two Intl.NumberFormat tests
Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently.
Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation.
[1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_triggered/builds/16490/steps/Test262%20-%20no%20variants
BUG=v8:6015, v8:6016
TBR=adamk@chromium.org,littledan@chromium.org
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2717773002
Cr-Commit-Position: refs/heads/master@{#43423}
Committed: https://chromium.googlesource.com/v8/v8/+/0ccb028121ed4c6ecd2435c0c1a31372acecd8b4
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
Description was changed from ========== [test262] unblock commit queue Currently try bots are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. BUG=v8:6015 TBR=adamk@chromium.org,littledan@chromium.org ========== to ========== [test262] unblock commit queue Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015 TBR=adamk@chromium.org,littledan@chromium.org ==========
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Description was changed from ========== [test262] unblock commit queue Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015 TBR=adamk@chromium.org,littledan@chromium.org ========== to ========== [test262] unblock commit queue Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015 TBR=adamk@chromium.org,littledan@chromium.org ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [test262] unblock commit queue Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015 TBR=adamk@chromium.org,littledan@chromium.org ========== to ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015 TBR=adamk@chromium.org,littledan@chromium.org ==========
I'll land this to unblock commit queue as soon as it passes try bots. But it definitely requires more investigations. I don't completely understand where try bots fetch these tests and I'm not able to reproduce this failure locally. To reproduce it and check that this behavior was presented in V8 for recent commits - I downloaded these tests from try bot via swarming client.
The CQ bit was unchecked by kozyatinskiy@chromium.org
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015 TBR=adamk@chromium.org,littledan@chromium.org ========== to ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015,6016 TBR=adamk@chromium.org,littledan@chromium.org ==========
Description was changed from ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015,6016 TBR=adamk@chromium.org,littledan@chromium.org ========== to ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015,v8:6016 TBR=adamk@chromium.org,littledan@chromium.org ==========
Description was changed from ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015,v8:6016 TBR=adamk@chromium.org,littledan@chromium.org ========== to ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015,v8:6016 TBR=adamk@chromium.org,littledan@chromium.org NOTREECHECKS=true ==========
The CQ bit was unchecked by kozyatinskiy@chromium.org
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487979579678630, "parent_rev":
"d2c093bcafb0ec4795078424176e40ccb5f715aa", "commit_rev":
"0ccb028121ed4c6ecd2435c0c1a31372acecd8b4"}
Message was sent while issue was closed.
Description was changed from ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015,v8:6016 TBR=adamk@chromium.org,littledan@chromium.org NOTREECHECKS=true ========== to ========== [test262] skip two Intl.NumberFormat tests Currently try bots [1] are failing on these tests and no CLs can be landed to V8. It looks like these tests were added recently. Based on https://bugs.chromium.org/p/v8/issues/detail?id=6015, it's known issue in V8 implementation, so mark them as needs investigation. [1] https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_tri... BUG=v8:6015,v8:6016 TBR=adamk@chromium.org,littledan@chromium.org NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2717773002 Cr-Commit-Position: refs/heads/master@{#43423} Committed: https://chromium.googlesource.com/v8/v8/+/0ccb028121ed4c6ecd2435c0c1a31372ace... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/0ccb028121ed4c6ecd2435c0c1a31372ace...
Message was sent while issue was closed.
On 2017/02/24 23:41:30, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/v8/v8/+/0ccb028121ed4c6ecd2435c0c1a31372ace... I'm really sorry about this. I had a fix, but it was reverted due to breaking Windows bots in https://codereview.chromium.org/2640223003/ . I'm not sure what the right solution is; I would like to figure out how to reland https://codereview.chromium.org/2643983002 . machenback, do you have any ideas?
Message was sent while issue was closed.
On 2017/02/24 23:55:12, Dan Ehrenberg wrote: > On 2017/02/24 23:41:30, commit-bot: I haz the power wrote: > > Committed patchset #1 (id:1) as > > > https://chromium.googlesource.com/v8/v8/+/0ccb028121ed4c6ecd2435c0c1a31372ace... > > I'm really sorry about this. I had a fix, but it was reverted due to breaking > Windows bots in https://codereview.chromium.org/2640223003/ . I'm not sure what > the right solution is; I would like to figure out how to reland > https://codereview.chromium.org/2643983002 . machenback, do you have any ideas? Huh, I thought the issue was this: https://bugs.chromium.org/p/v8/issues/detail?id=5881
Message was sent while issue was closed.
On 2017/02/25 00:28:34, binji wrote: > On 2017/02/24 23:55:12, Dan Ehrenberg wrote: > > On 2017/02/24 23:41:30, commit-bot: I haz the power wrote: > > > Committed patchset #1 (id:1) as > > > > > > https://chromium.googlesource.com/v8/v8/+/0ccb028121ed4c6ecd2435c0c1a31372ace... > > > > I'm really sorry about this. I had a fix, but it was reverted due to breaking > > Windows bots in https://codereview.chromium.org/2640223003/ . I'm not sure > what > > the right solution is; I would like to figure out how to reland > > https://codereview.chromium.org/2643983002 . machenback, do you have any > ideas? > > Huh, I thought the issue was this: > https://bugs.chromium.org/p/v8/issues/detail?id=5881 Well, that's why a new tarfile didn't get rebuilt, but really, there's no reason to build a tarfile at all here; the other patch just didn't build it. Seems like this would be an easier short-term fix if the other fix is blocked on the swarming gn migration. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
