Set "Running" state only when actually running

Set "Running" state only when actually running

When resuming an AudioContext, the state should be set to "running"
when the context has actually started running again.  Previously, this
was set when resume() was called.  Depending on the device, it make
take a while before the device actually starts running, so we were
prematurely setting the state to "running".

This can't be tested in a layout test with offline context.

BUG=693978
TEST=none

Review-Url: https://codereview.chromium.org/2717613007
Cr-Commit-Position: refs/heads/master@{#455867}
Committed: https://chromium.googlesource.com/chromium/src/+/dc4cda062ada67cd3c845149d58a4dc7545a00c1

[Raymond Toy, 2017-02-27 17:12:43]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 17:13:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2017-02-27 17:13:19]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-02-27 17:13:19]

PTAL

[commit-bot: I haz the power, 2017-02-27 18:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 18:18:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hongchan, 2017-02-28 17:49:25]

The change looks good. Does this really fix the issue?

[Raymond Toy, 2017-02-28 19:30:07]

On 2017/02/28 at 17:49:25, hongchan wrote:
> The change looks good. Does this really fix the issue?

My own tests using an AirPlay device (as reported in the bug) shows no apparent
difference with or without this CL.  Perhaps this is because the device is an
AVR and I should really try with, perhaps, an Airport basestation with speakers
attached.  I'll try that later.

In any case, I think it makes sense to set "running" when we deliver the promise
when the audio hardware as started pulling data.

[hongchan, 2017-03-03 16:02:11]

lgtm

[Raymond Toy, 2017-03-08 16:06:48]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-03-08 16:07:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 17:08:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 17:08:19]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raymond Toy, 2017-03-08 23:04:23]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-03-08 23:05:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 00:03:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 00:03:46]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Raymond Toy, 2017-03-09 16:30:40]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-03-09 16:31:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 17:24:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 17:24:50]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Raymond Toy, 2017-03-09 19:55:19]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-03-09 19:55:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2717613007/#ps40001
(title: "State must be set AFTER startRendering().")

[commit-bot: I haz the power, 2017-03-09 19:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 21:23:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489089319882060,
"parent_rev": "0a3a302b6df6458b21b3ce0951c5251413cadc48", "commit_rev":
"dc4cda062ada67cd3c845149d58a4dc7545a00c1"}

[commit-bot: I haz the power, 2017-03-09 21:24:35]

Description was changed from

==========
Set "Running" state only when actually running

When resuming an AudioContext, the state should be set to "running"
when the context has actually started running again.  Previously, this
was set when resume() was called.  Depending on the device, it make
take a while before the device actually starts running, so we were
prematurely setting the state to "running".

This can't be tested in a layout test with offline context.

BUG=693978
TEST=none
==========

to

==========
Set "Running" state only when actually running

When resuming an AudioContext, the state should be set to "running"
when the context has actually started running again.  Previously, this
was set when resume() was called.  Depending on the device, it make
take a while before the device actually starts running, so we were
prematurely setting the state to "running".

This can't be tested in a layout test with offline context.

BUG=693978
TEST=none

Review-Url: https://codereview.chromium.org/2717613007
Cr-Commit-Position: refs/heads/master@{#455867}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc4cda062ada67cd3c845149d58a...
==========

[commit-bot: I haz the power, 2017-03-09 21:24:36]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dc4cda062ada67cd3c845149d58a...