third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h - Issue 2717613007: Set "Running" state only when actually running

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h

Issue 2717613007: Set "Running" state only when actually running (Closed)

Patch Set: State must be set AFTER startRendering(). Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h

diff --git a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h

index b3011004d5c9533d7dff2408cd0bfa44ea631ac0..63af742771c67bcdf0fbf27c3c4e2dede9fa26cb 100644

--- a/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h

+++ b/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h

@@ -305,7 +305,9 @@ class MODULES_EXPORT BaseAudioContext

DEFINE_ATTRIBUTE_EVENT_LISTENER(statechange);

- // Start the AudioContext. `isAllowedToStart()` MUST be called before.

+ // Start the AudioContext. `isAllowedToStart()` MUST be called

+ // before. This does NOT set the context state to running. The

+ // caller must set the state AFTER calling startRendering.

void startRendering();

void notifyStateChange();