Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Unified Diff: ios/web/web_state/blocked_popup_info.h

Issue 2717613006: Moved ios popup opening code from Tab to BlockedPopupTabHelper. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/test/web_test_with_web_state.mm ('k') | ios/web/web_state/blocked_popup_info.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/blocked_popup_info.h
diff --git a/ios/web/web_state/blocked_popup_info.h b/ios/web/web_state/blocked_popup_info.h
index 311a547256663f28f10ab4207ca6382a6ab49c44..dc76b81864af5c4565a96f1637dd2a97ebc90286 100644
--- a/ios/web/web_state/blocked_popup_info.h
+++ b/ios/web/web_state/blocked_popup_info.h
@@ -5,41 +5,28 @@
#ifndef IOS_WEB_WEB_STATE_BLOCKED_POPUP_INFO_H_
#define IOS_WEB_WEB_STATE_BLOCKED_POPUP_INFO_H_
-#import <Foundation/Foundation.h>
-
-#import "base/ios/block_types.h"
-#import "base/mac/scoped_nsobject.h"
#include "ios/web/public/referrer.h"
#include "url/gurl.h"
namespace web {
// Contain all information related to a blocked popup.
-// TODO(eugenebut): rename to BlockedPopup as it's not an info object anymore.
+// TODO(crbug.com/692117): Fold this class into BlockedPopupTabHelper.
class BlockedPopupInfo {
public:
- BlockedPopupInfo(const GURL& url,
- const Referrer& referrer,
- NSString* window_name,
- ProceduralBlock show_popup_handler);
+ BlockedPopupInfo(const GURL& url, const Referrer& referrer);
~BlockedPopupInfo();
// Returns the URL of the popup that was blocked.
const GURL& url() const { return url_; }
// Returns the Referrer of the URL that was blocked.
const Referrer& referrer() const { return referrer_; }
- // Returns the window name of the popup that was blocked.
- NSString* window_name() const { return window_name_; }
- // Allows the popup by opening the blocked popup window.
- void ShowPopup() const;
BlockedPopupInfo(const BlockedPopupInfo& blocked_popup_info);
void operator=(const BlockedPopupInfo& blocked_popup_info);
private:
GURL url_;
Referrer referrer_;
- base::scoped_nsobject<NSString> window_name_;
- ProceduralBlock show_popup_handler_;
};
} // namespace web
« no previous file with comments | « ios/web/public/test/web_test_with_web_state.mm ('k') | ios/web/web_state/blocked_popup_info.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698