Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: ios/web/public/test/web_test_with_web_state.mm

Issue 2717613006: Moved ios popup opening code from Tab to BlockedPopupTabHelper. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/public/test/web_test_with_web_state.h ('k') | ios/web/web_state/blocked_popup_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/public/test/web_test_with_web_state.mm
diff --git a/ios/web/public/test/web_test_with_web_state.mm b/ios/web/public/test/web_test_with_web_state.mm
index c704d647da97c95718c871176a1dd158cac043be..9b09c9e1183b105e55860c0ce93a9e9a2e7609df 100644
--- a/ios/web/public/test/web_test_with_web_state.mm
+++ b/ios/web/public/test/web_test_with_web_state.mm
@@ -39,7 +39,7 @@ void WebTestWithWebState::SetUp() {
}
void WebTestWithWebState::TearDown() {
- web_state_.reset();
+ DestroyWebState();
WebTest::TearDown();
}
@@ -132,6 +132,10 @@ id WebTestWithWebState::ExecuteJavaScript(NSString* script) {
return [[executionResult retain] autorelease];
}
+void WebTestWithWebState::DestroyWebState() {
+ web_state_.reset();
+}
+
std::string WebTestWithWebState::BaseUrl() const {
web::URLVerificationTrustLevel unused_level;
return web_state()->GetCurrentURL(&unused_level).spec();
« no previous file with comments | « ios/web/public/test/web_test_with_web_state.h ('k') | ios/web/web_state/blocked_popup_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698