Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: ios/web/web_state/blocked_popup_info.mm

Issue 2717613006: Moved ios popup opening code from Tab to BlockedPopupTabHelper. (Closed)
Patch Set: Rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/web_state/blocked_popup_info.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/blocked_popup_info.mm
diff --git a/ios/web/web_state/blocked_popup_info.mm b/ios/web/web_state/blocked_popup_info.mm
index b77023ee71461e8630fe7c81e23b789093fc9f43..65dcc97a79f5ccee2bbabdf5e890110d392626a9 100644
--- a/ios/web/web_state/blocked_popup_info.mm
+++ b/ios/web/web_state/blocked_popup_info.mm
@@ -10,34 +10,17 @@
namespace web {
-BlockedPopupInfo::BlockedPopupInfo(const GURL& url,
- const Referrer& referrer,
- NSString* window_name,
- ProceduralBlock show_popup_handler)
- : url_(url),
- referrer_(referrer),
- window_name_([window_name copy]),
- show_popup_handler_([show_popup_handler copy]) {
-}
+BlockedPopupInfo::BlockedPopupInfo(const GURL& url, const Referrer& referrer)
+ : url_(url), referrer_(referrer) {}
BlockedPopupInfo::BlockedPopupInfo(const BlockedPopupInfo& blocked_popup_info)
- : url_(blocked_popup_info.url_),
- referrer_(blocked_popup_info.referrer_),
- window_name_([blocked_popup_info.window_name_ copy]),
- show_popup_handler_([blocked_popup_info.show_popup_handler_ copy]) {
-}
+ : url_(blocked_popup_info.url_), referrer_(blocked_popup_info.referrer_) {}
BlockedPopupInfo::~BlockedPopupInfo() {}
-void BlockedPopupInfo::ShowPopup() const {
- show_popup_handler_();
-}
-
void BlockedPopupInfo::operator=(const BlockedPopupInfo& blocked_popup_info) {
url_ = blocked_popup_info.url_;
referrer_ = blocked_popup_info.referrer_;
- window_name_.reset([blocked_popup_info.window_name_ copy]);
- show_popup_handler_ = [blocked_popup_info.show_popup_handler_ copy];
}
} // namespace web
« no previous file with comments | « ios/web/web_state/blocked_popup_info.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698