ios/web/public/test/web_test_with_web_state.h - Issue 2717613006: Moved ios popup opening code from Tab to BlockedPopupTabHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/test/web_test_with_web_state.h

Issue 2717613006: Moved ios popup opening code from Tab to BlockedPopupTabHelper. (Closed)

Patch Set: Rebased Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/public/test/web_test_with_web_state.h

diff --git a/ios/web/public/test/web_test_with_web_state.h b/ios/web/public/test/web_test_with_web_state.h

index 74eb958d5b4c5509c66b0cecee1c2daec7ad72f8..b167056f398810c4538c4f91c8b2ff65a5f34798 100644

--- a/ios/web/public/test/web_test_with_web_state.h

+++ b/ios/web/public/test/web_test_with_web_state.h

@@ -39,6 +39,8 @@ class WebTestWithWebState : public WebTest,

void WaitForCondition(ConditionBlock condition);

// Synchronously executes JavaScript and returns result as id.

id ExecuteJavaScript(NSString* script);

+ // Destroys underlying WebState. web_state() will return null after this call.

+ void DestroyWebState();

// Returns the base URL of the loaded page.

std::string BaseUrl() const;