Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: chrome/browser/ui/cocoa/info_bubble_view.h

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/info_bubble_view.h
diff --git a/chrome/browser/ui/cocoa/info_bubble_view.h b/chrome/browser/ui/cocoa/info_bubble_view.h
index 09fa4745d458a39c377109d9048d2e046d1f891d..e89cc982eef519f5d53896edef3e816e362166e9 100644
--- a/chrome/browser/ui/cocoa/info_bubble_view.h
+++ b/chrome/browser/ui/cocoa/info_bubble_view.h
@@ -25,11 +25,12 @@ enum CornerFlags {
};
enum BubbleArrowLocation {
- kTopLeft,
+ kTopLeading,
kTopCenter,
- kTopRight,
+ kTopTrailing,
kNoArrow,
-};
+}
Elly Fong-Jones 2017/02/24 15:34:31 remove newline?
lgrey 2017/02/24 15:38:39 CL format made me do this! Will kill two birds wit
Nico 2017/02/24 15:52:09 That looks pretty bad :-( filed https://bugs.chrom
lgrey 2017/02/27 15:56:25 Thanks for the clang-format fix, done.
+;
enum BubbleAlignment {
// The tip of the arrow points to the anchor point.
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm ('k') | chrome/browser/ui/cocoa/info_bubble_view.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698