chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm - Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

Issue 2717603003: [Mac] Make bubble arrow location/position RTL-aware (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm ('k') | chrome/browser/ui/cocoa/info_bubble_view.h » ('j') | chrome/browser/ui/cocoa/info_bubble_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

diff --git a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

index 4099c11afbaaf524a944af7f5d8be1ae60cfd7f4..75177f2f4c2943bac07d5cc087634f39b32deed4 100644

--- a/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

+++ b/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

@@ -87,7 +87,7 @@ CGFloat kMinWidth = 320.0;

ui::NativeTheme* nativeTheme = ui::NativeTheme::GetInstanceForNativeUi();

[[self bubble] setAlignment:info_bubble::kAlignArrowToAnchor];

- [[self bubble] setArrowLocation:info_bubble::kTopRight];

+ [[self bubble] setArrowLocation:info_bubble::kTopTrailing];

[[self bubble] setBackgroundColor:

skia::SkColorToCalibratedNSColor(nativeTheme->GetSystemColor(

ui::NativeTheme::kColorId_DialogBackground))];