Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2717413003: Add support for logging additional metrics in UKM. (Closed)

Created:
3 years, 9 months ago by Bryan McQuade
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, csharrison+watch_chromium.org, asvitkine+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for logging additional metrics in UKM. BUG=

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : fix naming #

Patch Set 4 : record URL at nav start #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -35 lines) Patch
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.h View 1 2 3 chunks +13 lines, -2 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc View 1 2 3 2 chunks +52 lines, -14 lines 0 comments Download
M chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc View 1 2 3 chunks +33 lines, -8 lines 0 comments Download
M components/metrics/proto/ukm/source.proto View 1 2 1 chunk +23 lines, -1 line 0 comments Download
M components/ukm/ukm_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ukm/ukm_source.h View 1 2 2 chunks +27 lines, -6 lines 0 comments Download
M components/ukm/ukm_source.cc View 1 2 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (10 generated)
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-27 19:05:34 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717413003/1
3 years, 9 months ago (2017-02-27 19:06:18 UTC) #2
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-27 19:11:08 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717413003/20001
3 years, 9 months ago (2017-02-27 19:11:15 UTC) #4
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-27 19:22:57 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717413003/40001
3 years, 9 months ago (2017-02-27 19:23:26 UTC) #6
Bryan McQuade
The CQ bit was checked by bmcquade@chromium.org to run a CQ dry run
3 years, 9 months ago (2017-02-27 20:00:59 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2717413003/60001
3 years, 9 months ago (2017-02-27 20:01:22 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 9 months ago (2017-02-27 21:14:20 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 21:14:21 UTC) #10 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698