components/ukm/ukm_service_unittest.cc - Issue 2717413003: Add support for logging additional metrics in UKM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ukm/ukm_service_unittest.cc

Issue 2717413003: Add support for logging additional metrics in UKM. (Closed)

Patch Set: record URL at nav start Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ukm/ukm_service_unittest.cc

diff --git a/components/ukm/ukm_service_unittest.cc b/components/ukm/ukm_service_unittest.cc

index be8090c2724d565c99244ac3a32f7e02d4cc14bd..c55492fba413259d52f793947491fee14de274cb 100644

--- a/components/ukm/ukm_service_unittest.cc

+++ b/components/ukm/ukm_service_unittest.cc

@@ -63,7 +63,7 @@ class UkmServiceTest : public testing::Test {

std::unique_ptr<UkmSource> MakeSource(std::string url, int paint_msec) {

auto source = base::MakeUnique<UkmSource>();

- source->set_committed_url(GURL(url));

+ source->set_url(GURL(url));

source->set_first_contentful_paint(

base::TimeDelta::FromMilliseconds(paint_msec));

return source;

« no previous file with comments | « components/metrics/proto/ukm/source.proto ('k') | components/ukm/ukm_source.h » ('j') | no next file with comments »